View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000998OpenFOAMBugpublic2013-09-08 14:432013-09-18 14:13
Reporterdkxls Assigned Touser2 
PrioritynormalSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
PlatformLinux x86_64OSopenSUSEOS Version12.2
Summary0000998: [SprayParcel]: Momentum relaxation time not store consistently in the parcel properties
DescriptionThe momentum relaxation time tMom is only for parcels added by the breakup model stored in the respective parcel properties.

The information about the momentum relaxation time is valuable for post-processing and the changes are minimal (see provided patch).

It could also be considered to store this information already in the KinematicParcel template, but I guess this would break backwards compatibility for non-spray solvers.
TagsNo tags attached.

Activities

dkxls

2013-09-08 14:43

reporter  

0001-Store-tMom-consistently-in-the-parcel-properties.patch (1,304 bytes)    
From 483489b7ff7eb1cd4a5a72abc61e5b367fb5cb9a Mon Sep 17 00:00:00 2001
From: Armin Wehrfritz <armin.wehrfritz@aalto.fi>
Date: Sun, 8 Sep 2013 13:12:36 +0300
Subject: [PATCH] Store tMom consistently in the parcel properties

---
 src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C b/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C
index ed96db0..2d6841a 100644
--- a/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C
+++ b/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C
@@ -259,7 +259,7 @@ void Foam::SprayParcel<ParcelType>::calcBreakup
     const scalar mass = p.mass();
     const forceSuSp Fcp = forces.calcCoupled(p, dt, mass, Re, muAv);
     const forceSuSp Fncp = forces.calcNonCoupled(p, dt, mass, Re, muAv);
-    scalar tMom = mass/(Fcp.Sp() + Fncp.Sp());
+    this->tMom() = mass/(Fcp.Sp() + Fncp.Sp());
 
     const vector g = td.cloud().g().value();
 
@@ -287,7 +287,7 @@ void Foam::SprayParcel<ParcelType>::calcBreakup
             muAv,
             Urel,
             Urmag,
-            tMom,
+            this->tMom(),
             dChild,
             massChild
         )
-- 
1.8.1.4
0001-Store-tMom-consistently-in-the-parcel-properties.patch (1,304 bytes)   

user2

2013-09-18 14:13

  ~0002498

Thanks for the report - fixed by commit cfc4fb0

Issue History

Date Modified Username Field Change
2013-09-08 14:43 dkxls New Issue
2013-09-08 14:43 dkxls File Added: 0001-Store-tMom-consistently-in-the-parcel-properties.patch
2013-09-18 14:13 user2 Note Added: 0002498
2013-09-18 14:13 user2 Status new => resolved
2013-09-18 14:13 user2 Fixed in Version => 2.2.x
2013-09-18 14:13 user2 Resolution open => fixed
2013-09-18 14:13 user2 Assigned To => user2