View Issue Details

IDProjectCategoryView StatusLast Update
0000988OpenFOAMBugpublic2013-09-03 08:50
Reporteruser19Assigned Touser4 
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Summary0000988: metisDecomp.C calls decompositionMethod::calcCellCells with too few arguments
DescriptionJust in case you want to revive METIS, now that it is Apache v2 licensed...
Additional InformationAttached patch fixes this.
TagsNo tags attached.

Activities

user19

2013-09-02 16:34

 

0001-FIX-Updated-metisDecomp.C-to-new-decompositionMethod.patch (1,549 bytes)   
From 8d0489ad9b47609abaadcb1ccedbca7aef0ba377 Mon Sep 17 00:00:00 2001
From: Michael Wild <themiwi@users.sourceforge.net>
Date: Mon, 2 Sep 2013 17:10:51 +0200
Subject: [PATCH] FIX: Updated metisDecomp.C to new
 decompositionMethod::calcCellCells() signature

Signed-off-by: Michael Wild <themiwi@users.sourceforge.net>
---
 src/parallel/decompose/metisDecomp/metisDecomp.C | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/src/parallel/decompose/metisDecomp/metisDecomp.C b/src/parallel/decompose/metisDecomp/metisDecomp.C
index e1614a8..22eb38e 100644
--- a/src/parallel/decompose/metisDecomp/metisDecomp.C
+++ b/src/parallel/decompose/metisDecomp/metisDecomp.C
@@ -328,7 +328,14 @@ Foam::labelList Foam::metisDecomp::decompose
     }
 
     CompactListList<label> cellCells;
-    calcCellCells(mesh, identity(mesh.nCells()), mesh.nCells(), cellCells);
+    calcCellCells
+    (
+        mesh,
+        identity(mesh.nCells()),
+        mesh.nCells(),
+        true,
+        cellCells
+    );
 
     // Decompose using default weights
     labelList decomp;
@@ -362,7 +369,14 @@ Foam::labelList Foam::metisDecomp::decompose
     //   xadj(celli) : start of information in adjncy for celli
 
     CompactListList<label> cellCells;
-    calcCellCells(mesh, agglom, agglomPoints.size(), cellCells);
+    calcCellCells
+    (
+        mesh,
+        agglom,
+        agglomPoints.size(),
+        true,
+        cellCells
+    );
 
     // Decompose using default weights
     labelList finalDecomp;
-- 
1.8.1.2

user4

2013-09-03 08:50

  ~0002450

Pushed change to 82d05650163feda43d66fde1bea74279ec4b7306.

Note that the new Metis (5.1, the Apache licensed one) has a slightly different API. In the next major release this version will be fully supported.

Issue History

Date Modified Username Field Change
2013-09-02 16:34 user19 New Issue
2013-09-02 16:34 user19 File Added: 0001-FIX-Updated-metisDecomp.C-to-new-decompositionMethod.patch
2013-09-03 08:50 user4 Note Added: 0002450
2013-09-03 08:50 user4 Status new => resolved
2013-09-03 08:50 user4 Fixed in Version => 2.2.x
2013-09-03 08:50 user4 Resolution open => fixed
2013-09-03 08:50 user4 Assigned To => user4