View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000095OpenFOAMBugpublic2010-12-01 10:012012-03-19 11:58
Reporteruser19Assigned Touser2 
PrioritylowSeveritytrivialReproducibilityN/A
Status resolvedResolutionfixed 
Summary0000095: Dead/orphanded files
DescriptionThe following files are rather easy-to-find orphans. The criteria where:

- .C suffix
- Does not show up in any Make/files
- Is not #include'd in a another source file

Then, I looked whether I could find corresponding headers (.H) files that where also orphaned, and also included them in the list. This was followed up by "grepping" for all the basenames and manual inspection to make extra sure that these files are actually unused.

applications/solvers/combustion/PDRFoam/PDRFoamAutoRefine.C
applications/solvers/heatTransfer/chtMultiRegionSimpleFoam/fluid/compressibleCourantNo.C
applications/test/graph/graphTest2.C
applications/test/nearWallDist-wave/testWallDist2.C
applications/test/nearWallDist-wave/testWallDistData.C
applications/test/nearWallDist-wave/testYPlus.C
applications/utilities/mesh/conversion/cfx4ToFoam/block.H
applications/utilities/mesh/conversion/cfx4ToFoam/block.C
applications/utilities/postProcessing/dataConversion/foamToTecplot360/tecio/examples/comtest/comtest.c
applications/utilities/postProcessing/dataConversion/foamToTecplot360/tecio/examples/simtest/simtest.c
applications/utilities/postProcessing/miscellaneous/postChannel/sumData.H
applications/utilities/postProcessing/miscellaneous/postChannel/sumData.C
applications/utilities/surface/surfaceCoarsen/bunnylod/bunnygut.C
applications/utilities/surface/surfaceCoarsen/bunnylod/rabdata.C
applications/utilities/surface/surfaceCoarsen/bunnylod/winmain.C
src/OpenFOAM/db/IOstreams/Sstreams/chkStream.C
src/OpenFOAM/db/IOstreams/Sstreams/state.C
src/OpenFOAM/graph/curve/curveTools.H
src/OpenFOAM/graph/curve/curveTools.C
src/OpenFOAM/matrices/tolerances/tolerances.H
src/OpenFOAM/matrices/tolerances/tolerances.C
src/OpenFOAM/primitives/random/random.c
src/OpenFOAM/primitives/random/random.3
src/postProcessing/functionObjects/utilities/dsmcFields/IOdsmcFields.C
src/thermophysicalModels/specie/transport/speciesTransport/speciesTransport.H
src/thermophysicalModels/specie/transport/speciesTransport/speciesTransport.C


I suspect there are more orphaned files (especially header-only stuff), but those are much more difficult to find.
TagsNo tags attached.

Activities

user19

2010-12-01 10:02

  ~0000147

Ugh, sorry for the messy report. Seems like Mantis decided to just ditch all the newlines...

user4

2010-12-13 10:41

  ~0000176

Thanks for report. We'll keep it in mind when we come across these files.

For now:
applications/solvers/combustion/PDRFoam/PDRFoamAutoRefine.C : alternative solver. Added to Make/files
foamToTecplot360/tecio : not our code.
postChannel/sumData.H/C : removed

user19

2010-12-16 10:29

  ~0000182

There are still more orphaned files, not just the ones you fixed:

(That one's left from copying chtMultiRegionFoam)

applications/solvers/heatTransfer/chtMultiRegionSimpleFoam/fluid/compressibleCourantNo.C

(Not sure what the larger plan with these test programs is anyways...)

applications/test/graph/graphTest2.C

applications/test/nearWallDist-wave/testWallDist2.C

applications/test/nearWallDist-wave/testWallDistData.C

applications/test/nearWallDist-wave/testYPlus.C

(cfx4ToFoam probably started off as a copy of blockMesh, right?)

applications/utilities/mesh/conversion/cfx4ToFoam/block.H

applications/utilities/mesh/conversion/cfx4ToFoam/block.C

(That one's mentioned as being a source file of OSstream.H in the header comment, but actually is never included/compiled)

src/OpenFOAM/db/IOstreams/Sstreams/chkStream.C

(plain dead, no mentioning anywhere)

src/OpenFOAM/db/IOstreams/Sstreams/state.C

src/postProcessing/functionObjects/utilities/dsmcFields/IOdsmcFields.C

(The next .H/.C pairs only reference each other -> dead)

src/OpenFOAM/graph/curve/curveTools.H

src/OpenFOAM/graph/curve/curveTools.C

src/OpenFOAM/matrices/tolerances/tolerances.H

src/OpenFOAM/matrices/tolerances/tolerances.C

src/thermophysicalModels/specie/transport/speciesTransport/speciesTransport.H

src/thermophysicalModels/specie/transport/speciesTransport/speciesTransport.C

(Is there any platform that still has no/crappy implementation of random()?)

src/OpenFOAM/primitives/random/random.c

src/OpenFOAM/primitives/random/random.3

user19

2011-07-22 14:35

  ~0000585

The dead files applications/utilities/mesh/conversion/cfx4ToFoam/block.[CH] are still present in OpenFOAM-2.0.x...

henry

2011-07-23 14:22

manager   ~0000586

Removed cfx4ToFoam/block.[CH] file, the rest of the remaining files are needed for reference, future use or testing.

commit 85cd312894868303b553192a514dbe91ba49d307

user19

2012-03-19 09:57

  ~0001141

Last edited: 2012-03-19 09:58

 More files cropped up in 2.1.x: src/lagrangian/molecularDynamics/old

Andy told me that these files should have been removed, that's why I reopened this issue to report this new set of orphaned files.

user2

2012-03-19 11:58

  ~0001143

Thanks for the report - files removed under commit 5fb9751

Issue History

Date Modified Username Field Change
2010-12-01 10:01 user19 New Issue
2010-12-01 10:02 user19 Note Added: 0000147
2010-12-13 10:41 user4 Note Added: 0000176
2010-12-16 10:13 user2 Status new => closed
2010-12-16 10:13 user2 Resolution open => suspended
2010-12-16 10:29 user19 Note Added: 0000182
2010-12-16 10:29 user19 Status closed => feedback
2010-12-16 10:29 user19 Resolution suspended => reopened
2011-07-22 14:35 user19 Note Added: 0000585
2011-07-22 14:35 user19 Status feedback => new
2011-07-23 14:22 henry Note Added: 0000586
2011-07-23 14:22 henry Status new => resolved
2011-07-23 14:22 henry Resolution reopened => fixed
2011-07-23 14:22 henry Assigned To => henry
2012-03-19 09:57 user19 Note Added: 0001141
2012-03-19 09:57 user19 Status resolved => feedback
2012-03-19 09:57 user19 Resolution fixed => reopened
2012-03-19 09:58 user19 Note Edited: 0001141
2012-03-19 11:58 user2 Note Added: 0001143
2012-03-19 11:58 user2 Status feedback => resolved
2012-03-19 11:58 user2 Fixed in Version => 2.1.x
2012-03-19 11:58 user2 Resolution reopened => fixed
2012-03-19 11:58 user2 Assigned To henry => user2