View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000881 | OpenFOAM | Bug | public | 2013-06-09 08:53 | 2013-07-18 14:27 |
| Reporter | Assigned To | ||||
| Priority | high | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Ubuntu | OS Version | 10.04 |
| Summary | 0000881: bugs in regionModel1D::initialise() member functions. | ||||
| Description | It seems that boundaryFaceFaces_ is used to store the id of the faces parallel to the given boundary face. And all the boundary faces of different coupled patches are stored together. If this is the case, it gives a wrong id for boundaryFaceFaces_, in line 135 of reginModel1D.C const labelList& faces = boundaryFaceFaces_[localFaceI]; localFace here is the local index for current face in the current patch, but not the index it should be if there are two or more coupled patches. Thus, we have to introduce another variable to access faceid stored boundaryFaceFaces_ similar localPyrolysisFaceI when they are stored. add the following line before line 125 [ forAll(intCoupledPatchIDs_, i) int localCoupledPatchFacesId = 0 ; and changed line 135 from const labelList& faces = boundaryFaceFaces_[localFaceI]; to (==>) const labelList& faces = boundaryFaceFaces_[localCoupledPatchFacesId++]; is it right? regards, Junwei | ||||
| Tags | No tags attached. | ||||
|
|
Actually localFaceI in linr 132 is just a counter. It is indexing pNormal in the same way that you proposed solution. Regards |
|
|
If there is only one coupled patch, it is. But if there are two or more coupled patches, they are different. |
|
|
Corrected on commit 194e291078c16bfc36334d8b97bb42cd6775a488 |
|
|
194e291078c16bfc36334d8b97bb42cd6775a488 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-06-09 08:53 |
|
New Issue | |
| 2013-06-10 11:07 |
|
Note Added: 0002268 | |
| 2013-06-10 11:07 |
|
Status | new => resolved |
| 2013-06-10 11:07 |
|
Resolution | open => fixed |
| 2013-06-10 11:07 |
|
Assigned To | => user21 |
| 2013-06-13 17:12 |
|
Note Added: 0002279 | |
| 2013-06-13 17:12 |
|
Status | resolved => feedback |
| 2013-06-13 17:12 |
|
Resolution | fixed => reopened |
| 2013-06-13 17:37 |
|
Note Added: 0002280 | |
| 2013-07-18 14:27 |
|
Note Added: 0002338 | |
| 2013-07-18 14:27 |
|
Status | feedback => resolved |
| 2013-07-18 14:27 |
|
Fixed in Version | => 2.2.x |
| 2013-07-18 14:27 |
|
Resolution | reopened => fixed |
