View Issue Details

IDProjectCategoryView StatusLast Update
0000673OpenFOAMBugpublic2012-10-27 21:27
Reporterwyldckat Assigned Tohenry  
PrioritynormalSeveritytrivialReproducibilityalways
Status resolvedResolutionfixed 
Summary0000673: Inconsistency in defining PINC and PLIBS variables when using WM_MPLIB=SYSTEMOPENMPI
DescriptionI've noticed only today this inconsistency, where in the file "etc/config/settings.sh" one can find these lines for the SYSTEMOPENMPI option:

      # Set compilation flags here instead of in wmake/rules/../mplibSYSTEMOPENMPI
      export PINC="`mpicc --showme:compile`"
      export PLIBS="`mpicc --showme:link`"

But then in the General file "wmake/rules/General/mplibSYSTEMOPENMPI" we can find this:

   # use the system installed openmpi - mpicc must be installed

   PFLAGS = -DOMPI_SKIP_MPICXX
   PINC = $(shell mpicc --showme:compile)
   PLIBS = $(shell mpicc --showme:link)

I believe the two lines on this last file should be removed or at least commented out by default... or perhaps the other way around, by commenting out in the "settings.h" file!?

Nonetheless, I have not yet tested if things will still work as intended...

This is in reference to the latest commit 949ec0dcff28d2e0f44aa62a28f3e328d65bffad.
Additional InformationI only noticed this issue when giving some assistance on this thread and particular post: http://www.cfd-online.com/Forums/openfoam-installation/93341-system-openmpi-rhel-cluster.html#post388702
TagsNo tags attached.

Activities

henry

2012-10-27 18:21

manager   ~0001750

I don't see the inconsistency:

      export PINC="`mpicc --showme:compile`"
      export PLIBS="`mpicc --showme:link`"

and

   PINC = $(shell mpicc --showme:compile)
   PLIBS = $(shell mpicc --showme:link)

look consistent to me.

wyldckat

2012-10-27 19:10

updater   ~0001751

Sorry about that... The "inconsistency" I was trying to point out is because of this comment in the "settings.sh" file above the two export lines:

  # Set compilation flags here instead of in wmake/rules/../mplibSYSTEMOPENMPI

If the user pays attention to this comment and only modifies "PINC" and "PLIBS" in "settings.sh" (as some have done by using the system's mpich2 or mvapich2, because it's convenient), he/she ends up having to back track the steps taken after the build and come to the conclusion that the comment is misleading, having then to set the values in both files, or to try commenting out the lines in the rule file.

henry

2012-10-27 19:28

manager   ~0001752

OK thanks for the clarification, I will review and fix

henry

2012-10-27 19:50

manager   ~0001753

Thanks for the bug-report. I have removed the creation of the additional environment variables from etc/config/settings.sh as this is better handled locally to the wmake system as for the other MPI implementations.

Resolved by commit 8064dab1659afd6b54615458ef10f50d61d5793e

wyldckat

2012-10-27 20:12

updater   ~0001754

You're welcome.
I saw just now the fix and remembered+checked that "etc/config/settings.csh" should also get the same fix...

henry

2012-10-27 21:27

manager   ~0001755

Done but not tested. Please reopen if there are any issues.

Issue History

Date Modified Username Field Change
2012-10-27 17:11 wyldckat New Issue
2012-10-27 18:21 henry Note Added: 0001750
2012-10-27 19:10 wyldckat Note Added: 0001751
2012-10-27 19:28 henry Note Added: 0001752
2012-10-27 19:50 henry Note Added: 0001753
2012-10-27 19:50 henry Status new => resolved
2012-10-27 19:50 henry Resolution open => fixed
2012-10-27 19:50 henry Assigned To => henry
2012-10-27 20:12 wyldckat Note Added: 0001754
2012-10-27 20:12 wyldckat Status resolved => feedback
2012-10-27 20:12 wyldckat Resolution fixed => reopened
2012-10-27 21:27 henry Note Added: 0001755
2012-10-27 21:27 henry Status feedback => resolved
2012-10-27 21:27 henry Resolution reopened => fixed