View Issue Details

IDProjectCategoryView StatusLast Update
0000569OpenFOAM[All Projects] Bugpublic2012-07-01 21:37
ReporterwyldckatAssigned Tohenry 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0000569: Single Precision issue on compressibleTwoPhaseEulerFoam/kineticTheoryModels
DescriptionThe file "compressibleTwoPhaseEulerFoam/kineticTheoryModels/radialModel/SinclairJackson/SinclairJacksonRadial.C" won't build in SP due to double value "1e-06".

See attached patch for possible fix.
TagsNo tags attached.

Activities

wyldckat

2012-07-01 17:37

updater  

SinclairJacksonRadial.C.patch (896 bytes)
diff --git a/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/kineticTheoryModels/radialModel/SinclairJackson/SinclairJacksonRadial.C b/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/kineticTheoryModels/radialModel/SinclairJackson/SinclairJacksonRadial.C
index 74e8dac..67fea7d 100644
--- a/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/kineticTheoryModels/radialModel/SinclairJackson/SinclairJacksonRadial.C
+++ b/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/kineticTheoryModels/radialModel/SinclairJackson/SinclairJacksonRadial.C
@@ -85,7 +85,7 @@ Foam::kineticTheoryModels::radialModels::SinclairJackson::g0prime
 ) const
 {
     return
-       (1.0/3.0)*pow(max(alpha, 1.0e-6)/alphaMax, -2.0/3.0)
+       (1.0/3.0)*pow(max(alpha, scalar(1.0e-6))/alphaMax, -2.0/3.0)
       /(alphaMax*sqr(1.0 - pow(alpha/alphaMax, 1.0/3.0)));
 }
 

wyldckat

2012-07-01 20:56

updater   ~0001433

I forgot to check the other "SinclairJacksonRadial.C" files. The same fix applies to "applications/solvers/multiphase/twoPhaseEulerFoam/kineticTheoryModels", with "patch -p6".

henry

2012-07-01 21:37

manager   ~0001434

Resolved by commit 2978c3a3878d946abe929f74ee1c3c559a456ec8

Issue History

Date Modified Username Field Change
2012-07-01 17:37 wyldckat New Issue
2012-07-01 17:37 wyldckat File Added: SinclairJacksonRadial.C.patch
2012-07-01 20:56 wyldckat Note Added: 0001433
2012-07-01 21:37 henry Note Added: 0001434
2012-07-01 21:37 henry Status new => resolved
2012-07-01 21:37 henry Resolution open => fixed
2012-07-01 21:37 henry Assigned To => henry