View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004213 | OpenFOAM | Bug | public | 2025-02-07 07:04 | 2025-02-07 14:37 |
| Reporter | bonnymei | Assigned To | henry | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Product Version | dev | ||||
| Summary | 0004213: seemingly unnecessary implementation of the member function, correct, in the abstract class eddyViscosity | ||||
| Description | In the declaration of the eddyViscosity class, the void correct() member function is declared as a pure virtual function. However, in eddyViscosity.C, it is defined as follows template<class BasicMomentumTransportModel> void Foam::eddyViscosity<BasicMomentumTransportModel>::correct() { BasicMomentumTransportModel::correct(); } However, if I am not mistaken, the code does not seem to function and appears to be misleading and unnecessary. | ||||
| Tags | No tags attached. | ||||
|
|
Have you tried removing this function and compiled all of OpenFOAM and run the test-loop? |
|
|
When I compiled it, I found that an error occurred during the compilation of boundaryFoam because it couldn’t find a reference to the correct function of eddyViscosity. Would the implementation in eddyViscosity.C be the appropriate fix to prevent this error? |
|
|
I found that several parts of OpenFOAM did not compile with your proposed change and worse most applications did not run because the function was missing and needed by the linker. If I include the change you propose OpenFOAM will become useless. |
|
|
The proposed change breaks OpenFOAM badly in several ways and hence cannot be included. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-02-07 07:04 | bonnymei | New Issue | |
| 2025-02-07 08:38 | henry | Note Added: 0013525 | |
| 2025-02-07 14:14 | bonnymei | Note Added: 0013526 | |
| 2025-02-07 14:35 | henry | Note Added: 0013527 | |
| 2025-02-07 14:37 | henry | Assigned To | => henry |
| 2025-02-07 14:37 | henry | Status | new => closed |
| 2025-02-07 14:37 | henry | Resolution | open => no change required |
| 2025-02-07 14:37 | henry | Note Added: 0013528 |
