View Issue Details

IDProjectCategoryView StatusLast Update
0004195OpenFOAMBugpublic2024-12-31 12:58
Reporterwyldckat Assigned Tohenry  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Versiondev 
Summary0004195: Function 'getOldValues' in 'wmake/wmakePrintBuild' does not properly separate package from version
DescriptionIn the following snippet:

  getOldValues()
  {
      set -- "$(tail -1 "$build" 2>/dev/null)"

The outer quotes should not be used.
This is because using the outer quotes will result in the complete content of the '.build' file being passed to 'set' as a single argument, since it's within quotes.

Namely the code should be as follows:

  getOldValues()
  {
      set -- $(tail -1 "$build" 2>/dev/null)

so that each space-separated string is passed as an individual argument to 'set'.
Steps To ReproduceNot having this fix, results in having package-themed builds to always rebuild, even when there are no new commits.
This is because the current version 'dev-abcdef223' is different from 'dev-abcdef223 openfoam.org'.
Additional InformationThis occurs since OpenFOAM 6, see commit 0cca22576295ee1b1aa55e10dbdf42cf084025ca: https://github.com/OpenFOAM/OpenFOAM-6/commit/0cca22576295ee1b1aa55e10dbdf42cf084025ca#diff-922d485a6dd77c9c083d956efd24daf4efb4228ada2b3f83212f77913afce271R122
TagsNo tags attached.

Activities

henry

2024-12-31 12:58

manager   ~0013496

Resolved by commit 78c0718aeca6625084042784fdc03f2a6195ab36

Issue History

Date Modified Username Field Change
2024-12-31 12:34 wyldckat New Issue
2024-12-31 12:58 henry Assigned To => henry
2024-12-31 12:58 henry Status new => resolved
2024-12-31 12:58 henry Resolution open => fixed
2024-12-31 12:58 henry Note Added: 0013496