View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004195 | OpenFOAM | Bug | public | 2024-12-31 12:34 | 2024-12-31 12:58 |
Reporter | wyldckat | Assigned To | henry | ||
Priority | low | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | dev | ||||
Summary | 0004195: Function 'getOldValues' in 'wmake/wmakePrintBuild' does not properly separate package from version | ||||
Description | In the following snippet: getOldValues() { set -- "$(tail -1 "$build" 2>/dev/null)" The outer quotes should not be used. This is because using the outer quotes will result in the complete content of the '.build' file being passed to 'set' as a single argument, since it's within quotes. Namely the code should be as follows: getOldValues() { set -- $(tail -1 "$build" 2>/dev/null) so that each space-separated string is passed as an individual argument to 'set'. | ||||
Steps To Reproduce | Not having this fix, results in having package-themed builds to always rebuild, even when there are no new commits. This is because the current version 'dev-abcdef223' is different from 'dev-abcdef223 openfoam.org'. | ||||
Additional Information | This occurs since OpenFOAM 6, see commit 0cca22576295ee1b1aa55e10dbdf42cf084025ca: https://github.com/OpenFOAM/OpenFOAM-6/commit/0cca22576295ee1b1aa55e10dbdf42cf084025ca#diff-922d485a6dd77c9c083d956efd24daf4efb4228ada2b3f83212f77913afce271R122 | ||||
Tags | No tags attached. | ||||