View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004178 | OpenFOAM | Bug | public | 2024-11-14 09:37 | 2025-02-01 11:24 |
| Reporter | heatthinker | Assigned To | henry | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | AMD EPYC | OS | Ubuntu | OS Version | 22.04 |
| Product Version | 12 | ||||
| Fixed in Version | dev | ||||
| Summary | 0004178: fvSolution/PIMPLE controls do nothing | ||||
| Description | In the commit "https://github.com/OpenFOAM/OpenFOAM-12/commit/49ce8f65073e7e717331fbf1a3bead3075d4064d" it was mentioned that the frozenFlow control was replaced by a more general approach: PIMPLE { models yes; thermophysics no; flow no; . . . You can still find that these controls are read in the OF12 versions, fluidSolutionControl.H. "https://github.com/OpenFOAM/OpenFOAM-12/blob/master/src/finiteVolume/cfdTools/general/solutionControl/solutionControl/fluidSolutionControl/fluidSolutionControl.C" They are checked for a boolean value, but their functionality seems to be removed. I am guessing with the switch to the modular solver approach, since with that switch the tutorial "$FOAM_TUTORIALS/combustion/buoyantReactingFoam/Lagrangian/rivuletPanel" has also removed this functionality. | ||||
| Steps To Reproduce | Setting the controls to: PIMPLE { flow banana; } gives: --> FOAM FATAL IO ERROR: expected 'true/false', 'on/off' ... found banana Setting the control to PIMPLE { flow off; } does nothing. | ||||
| Additional Information | If this feature was indeed removed and or replaced, could you point me in the direction, of how I can reproduce this control setting within a multiRegion/CHT case. | ||||
| Tags | No tags attached. | ||||
|
|
I made a formatting error. Here are functional links: https://github.com/OpenFOAM/OpenFOAM-12/commit/49ce8f65073e7e717331fbf1a3bead3075d4064d https://github.com/OpenFOAM/OpenFOAM-12/blob/master/src/finiteVolume/cfdTools/general/solutionControl/solutionControl/fluidSolutionControl/fluidSolutionControl.C |
|
|
The "flow" and "thermophysics" options are still used by multiphaseEuler, if you do not need that solver and delete it you could remove these settings and functions from fluidSolutionControl. |
|
|
commit c822a9b786a38bdc8f885c1dfad9c616bf1efc9f (HEAD -> master, origin/master, origin/HEAD) Author: Henry Weller <http://cfd.direct> Date: Fri Jan 31 14:56:54 2025 +0000 Foam::solver: Added support for PIMPLE flow, thermophysics and models controls in ALL solver modules This required separating momentum and thermophysical transport prediction and correction in all solver modules by Adding //- Predict the momentum transport virtual void momentumTransportPredictor() = 0; //- Predict thermophysical transport virtual void thermophysicalTransportPredictor() = 0; and replacing //- Correct the momentum and thermophysical transport modelling virtual void postCorrector() = 0; with //- Correct the momentum transport virtual void momentumTransportCorrector() = 0; //- Correct the thermophysical transport virtual void thermophysicalTransportCorrector() = 0; This allowed the controls for transport prediction and correction to be moved from the solver modules into foamRun and foamMultiRun along with the PIMPLE flow, thermophysics and models controls from multiphaseEuler. Now in the PIMPLE controls in fvSolution the optional controls flow yes; thermophysics yes; models yes; are available to switch on/off these parts of the solution, in particular for complex CHT simulations in which the thermal time-scales are much longer than the fluid time-scales and it is advantageous to run the thermal system on a frozen flow field after it has evolved and then coupling the solution again after the thermal system has evolved. These switches can be changed at run-time allowing the flow and thermal systems to be switched on/off during the run. |
|
|
Resolved by commit c822a9b786a38bdc8f885c1dfad9c616bf1efc9f |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-11-14 09:37 | heatthinker | New Issue | |
| 2024-11-14 09:40 | heatthinker | Note Added: 0013462 | |
| 2024-11-14 10:38 | henry | Assigned To | => henry |
| 2024-11-14 10:38 | henry | Status | new => closed |
| 2024-11-14 10:38 | henry | Resolution | open => no change required |
| 2024-11-14 10:38 | henry | Note Added: 0013463 | |
| 2025-02-01 11:23 | henry | Note Added: 0013521 | |
| 2025-02-01 11:24 | henry | Status | closed => resolved |
| 2025-02-01 11:24 | henry | Resolution | no change required => fixed |
| 2025-02-01 11:24 | henry | Fixed in Version | => dev |
| 2025-02-01 11:24 | henry | Note Added: 0013522 |
