View Issue Details

IDProjectCategoryView StatusLast Update
0004178OpenFOAMBugpublic2024-11-14 10:38
Reporterheatthinker Assigned Tohenry  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
PlatformAMD EPYCOSUbuntuOS Version22.04
Product Version12 
Summary0004178: fvSolution/PIMPLE controls do nothing
DescriptionIn the commit "https://github.com/OpenFOAM/OpenFOAM-12/commit/49ce8f65073e7e717331fbf1a3bead3075d4064d" it was mentioned that the frozenFlow control was replaced by a more general approach:

PIMPLE
{
    models yes;
    thermophysics no;
    flow no;
    .
    .
    .


You can still find that these controls are read in the OF12 versions, fluidSolutionControl.H. "https://github.com/OpenFOAM/OpenFOAM-12/blob/master/src/finiteVolume/cfdTools/general/solutionControl/solutionControl/fluidSolutionControl/fluidSolutionControl.C"
They are checked for a boolean value, but their functionality seems to be removed. I am guessing with the switch to the modular solver approach, since with that switch the tutorial "$FOAM_TUTORIALS/combustion/buoyantReactingFoam/Lagrangian/rivuletPanel" has also removed this functionality.
Steps To ReproduceSetting the controls to:

PIMPLE
{
    flow banana;
}

gives:

--> FOAM FATAL IO ERROR:
expected 'true/false', 'on/off' ... found banana

Setting the control to

PIMPLE
{
    flow off;
}

does nothing.
Additional InformationIf this feature was indeed removed and or replaced, could you point me in the direction, of how I can reproduce this control setting within a multiRegion/CHT case.
TagsNo tags attached.

Activities

heatthinker

2024-11-14 09:40

reporter   ~0013462

I made a formatting error. Here are functional links:

https://github.com/OpenFOAM/OpenFOAM-12/commit/49ce8f65073e7e717331fbf1a3bead3075d4064d

https://github.com/OpenFOAM/OpenFOAM-12/blob/master/src/finiteVolume/cfdTools/general/solutionControl/solutionControl/fluidSolutionControl/fluidSolutionControl.C

henry

2024-11-14 10:38

manager   ~0013463

The "flow" and "thermophysics" options are still used by multiphaseEuler, if you do not need that solver and delete it you could remove these settings and functions from fluidSolutionControl.

Issue History

Date Modified Username Field Change
2024-11-14 09:37 heatthinker New Issue
2024-11-14 09:40 heatthinker Note Added: 0013462
2024-11-14 10:38 henry Assigned To => henry
2024-11-14 10:38 henry Status new => closed
2024-11-14 10:38 henry Resolution open => no change required
2024-11-14 10:38 henry Note Added: 0013463