View Issue Details

IDProjectCategoryView StatusLast Update
0004008OpenFOAMBugpublic2023-08-18 08:57
Reporterhandrake0724 Assigned Towill  
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0004008: incorrect and unused type in primitiveFaceZone.H
DescriptionI found that primitiveFaceZone type defined in primitiveFaceZone.H is not matching with the template declaration of PrimitivePatch which has 2 template parameters.

I checked older OpenFOAM versions and found that the type has been there since 2.x as far version as I could get.

I found that the change to the template parameter list of PrimitivePatch template class has been made in version 7 but the effect seems not propagated to primitiveFaceZone.H.

primitiveFaceZone type is not used in anywhere and the header file is not included at all.

So, I think the definition better change to match the current parameter list like

typedef PrimitivePatch(IndirectList<face>, const pointField&> primitiveFaceZone

This correction has the same form as primitivePatch introduced from version 7. I think primitiveFaceZone is an obsolete type and might be removed.

TagsNo tags attached.



2023-08-18 08:57

manager   ~0013101

Removed it. It is never used, as you say, and the "correct" form is already provided by indirectPrimitivePatch.

Issue History

Date Modified Username Field Change
2023-08-18 05:55 handrake0724 New Issue
2023-08-18 08:57 will Assigned To => will
2023-08-18 08:57 will Status new => resolved
2023-08-18 08:57 will Resolution open => fixed
2023-08-18 08:57 will Fixed in Version => dev
2023-08-18 08:57 will Note Added: 0013101