View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004008 | OpenFOAM | Bug | public | 2023-08-18 05:55 | 2023-08-18 08:57 |
| Reporter | handrake0724 | Assigned To | will | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0004008: incorrect and unused type in primitiveFaceZone.H | ||||
| Description | I found that primitiveFaceZone type defined in primitiveFaceZone.H is not matching with the template declaration of PrimitivePatch which has 2 template parameters. I checked older OpenFOAM versions and found that the type has been there since 2.x as far version as I could get. I found that the change to the template parameter list of PrimitivePatch template class has been made in version 7 but the effect seems not propagated to primitiveFaceZone.H. primitiveFaceZone type is not used in anywhere and the header file is not included at all. So, I think the definition better change to match the current parameter list like typedef PrimitivePatch(IndirectList<face>, const pointField&> primitiveFaceZone This correction has the same form as primitivePatch introduced from version 7. I think primitiveFaceZone is an obsolete type and might be removed. | ||||
| Tags | No tags attached. | ||||
|
|
Removed it. It is never used, as you say, and the "correct" form is already provided by indirectPrimitivePatch. https://github.com/OpenFOAM/OpenFOAM-dev/commit/4e7ee7ed65d556bb132401693a6f8649c0e70bb8 |
