View Issue Details

IDProjectCategoryView StatusLast Update
0003982OpenFOAMBugpublic2023-05-23 16:42
Reportercgoessni Assigned Tohenry  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0003982: egrMixture does not correctly consider egr fraction for low fuel mass fractions
DescriptionegrMixture assumes that parts of the "unburnt" (i.e. b=1) contain already burnt products. Thus, in https://github.com/OpenFOAM/OpenFOAM-dev/blob/master/src/thermophysicalModels/multicomponentThermo/mixtures/egrMixture/egrMixture.C#L77, just returning the oxidant if the fuel mass fraction is very low is not correct. Instead, the correct fractions of oxidant and products should be returned

- return oxidant_;
+ mixture_ = (1.0 - egr)*oxidant_;
+ mixture_ += egr*products_;

I attached a diff which would make egrMixture more corret.
TagsNo tags attached.

Activities

henry

2023-05-23 16:42

manager   ~0013026

Resolved by commit 6230721333ab7607aa23fdbfb840822cc44360ad

Issue History

Date Modified Username Field Change
2023-05-22 10:55 cgoessni New Issue
2023-05-22 10:55 cgoessni File Added: diff_egrMixture.txt
2023-05-22 11:18 administrator File Deleted: diff_egrMixture.txt
2023-05-23 16:42 henry Assigned To => henry
2023-05-23 16:42 henry Status new => resolved
2023-05-23 16:42 henry Resolution open => fixed
2023-05-23 16:42 henry Fixed in Version => dev
2023-05-23 16:42 henry Note Added: 0013026