View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000391 | OpenFOAM | Bug | public | 2012-01-18 21:04 | 2012-01-20 10:58 |
| Reporter | Assigned To | henry | |||
| Priority | low | Severity | text | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000391: Invalid encoding and typos in comments in dragModel.H of twoPhaseEulerFoam | ||||
| Description | The file applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H contains invalid characters in lines 117 and 121 and the comment in between has a typo. | ||||
| Additional Information | Attached patch fixes this and re-wraps the comment. | ||||
| Tags | No tags attached. | ||||
|
2012-01-18 21:04
|
0001-STYLE-Invalid-encoding-and-typos-in-comments-in-drag.patch (1,906 bytes)
From e7cfbf491542cbb6fb4b5199ab91a246559dab03 Mon Sep 17 00:00:00 2001
From: Michael Wild <themiwi@users.sourceforge.net>
Date: Wed, 18 Jan 2012 21:58:48 +0100
Subject: [PATCH] STYLE: Invalid encoding and typos in comments in dragModel.H
Signed-off-by: Michael Wild <themiwi@users.sourceforge.net>
---
.../dragModels/dragModel/dragModel.H | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H b/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
index a0364b8..181ffc0 100644
--- a/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
+++ b/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
@@ -114,11 +114,11 @@ public:
//- the dragfunction K used in the momentum eq.
// ddt(alpha*rhoa*Ua) + ... = ... alpha*beta*K*(Ua-Ub)
// ddt(beta*rhob*Ub) + ... = ... alpha*beta*K*(Ub-Ua)
- // **********************************�NB ! *****************************
- // for numerical reasons alpha and beta has been
- // extracted from the dragFunction K,
- // so you MUST divide K by alpha*beta when implemnting the drag function
- // **********************************�NB ! *****************************
+ // ********************************** NB ! *****************************
+ // for numerical reasons alpha and beta has been extracted from the
+ // dragFunction K, so you MUST divide K by alpha*beta when implementing
+ // the drag function
+ // ********************************** NB ! *****************************
virtual tmp<volScalarField> K(const volScalarField& Ur) const = 0;
};
--
1.7.5.4
|
|
|
Attached an updated patch with more fixes of the same nature. |
|
2012-01-19 07:57
|
0001-STYLE-Non-ascii-characters-and-typos-in-comments.patch (12,341 bytes)
From 2180566078f8bc95bb68f4ab0dcd4d9a0357914a Mon Sep 17 00:00:00 2001
From: Michael Wild <themiwi@users.sourceforge.net>
Date: Wed, 18 Jan 2012 21:58:48 +0100
Subject: [PATCH] STYLE: Non-ascii characters and typos in comments
Signed-off-by: Michael Wild <themiwi@users.sourceforge.net>
---
.../dragModels/dragModel/dragModel.H | 10 +++++-----
.../heatTransferModel/heatTransferModel.H | 11 +++++------
.../phaseChangeTwoPhaseMixtures/Kunz/Kunz.H | 4 ++--
.../dragModels/dragModel/dragModel.H | 10 +++++-----
.../heatTransferModel/heatTransferModel.H | 11 +++++------
.../dragModels/dragModel/dragModel.H | 10 +++++-----
.../molecule/reducedUnits/reducedUnits.H | 2 +-
.../old/reducedUnits/reducedUnits.H | 2 +-
.../RAS/SpalartAllmaras/SpalartAllmaras.H | 2 +-
.../RAS/SpalartAllmaras/SpalartAllmaras.H | 2 +-
10 files changed, 31 insertions(+), 33 deletions(-)
diff --git a/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H b/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
index 6d2add9..63df1ce 100644
--- a/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
+++ b/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
@@ -114,11 +114,11 @@ public:
//- the dragfunction K used in the momentum eq.
// ddt(alpha*rhoa*Ua) + ... = ... alpha*beta*K*(Ua-Ub)
// ddt(beta*rhob*Ub) + ... = ... alpha*beta*K*(Ub-Ua)
- // **********************************�NB ! *****************************
- // for numerical reasons alpha and beta has been
- // extracted from the dragFunction K,
- // so you MUST divide K by alpha*beta when implemnting the drag function
- // **********************************�NB ! *****************************
+ // ********************************** NB ! *****************************
+ // for numerical reasons alpha and beta has been extracted from the
+ // dragFunction K, so you MUST divide K by alpha*beta when implementing
+ // the drag function
+ // ********************************** NB ! *****************************
virtual tmp<volScalarField> K(const volScalarField& Ur) const = 0;
};
diff --git a/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H b/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H
index e4871f2..ad5de57 100644
--- a/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H
+++ b/applications/solvers/multiphase/compressibleTwoPhaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H
@@ -114,12 +114,11 @@ public:
//- the heat-transfer function K used in the enthalpy eq.
// ddt(alpha*rhoa*ha) + ... = ... alpha*beta*K*(Ta - Tb)
// ddt(beta*rhob*hb) + ... = ... alpha*beta*K*(Tb - Ta)
- // **********************************�NB ! *****************************
- // for numerical reasons alpha and beta has been
- // extracted from the heat-transfer function K,
- // so you MUST divide K by alpha*beta when implementing the
- // heat-transfer function
- // **********************************�NB ! *****************************
+ // ********************************** NB ! *****************************
+ // for numerical reasons alpha and beta has been extracted from the
+ // heat-transfer function K, so you MUST divide K by alpha*beta when
+ // implementing the heat-transfer function
+ // ********************************** NB ! *****************************
virtual tmp<volScalarField> K(const volScalarField& Ur) const = 0;
};
diff --git a/applications/solvers/multiphase/interPhaseChangeFoam/phaseChangeTwoPhaseMixtures/Kunz/Kunz.H b/applications/solvers/multiphase/interPhaseChangeFoam/phaseChangeTwoPhaseMixtures/Kunz/Kunz.H
index 31ea816..74f8f2b 100644
--- a/applications/solvers/multiphase/interPhaseChangeFoam/phaseChangeTwoPhaseMixtures/Kunz/Kunz.H
+++ b/applications/solvers/multiphase/interPhaseChangeFoam/phaseChangeTwoPhaseMixtures/Kunz/Kunz.H
@@ -35,8 +35,8 @@ Description
\verbatim
Kunz, R.F., Boger, D.A., Stinebring, D.R., Chyczewski, Lindau. J.W.,
Gibeling, H.J., Venkateswaran, S., Govindan, T.R.,
- “A Preconditioned Implicit Method for Two-Phase Flows with Application
- to Cavitation Prediction,”
+ "A Preconditioned Implicit Method for Two-Phase Flows with Application
+ to Cavitation Prediction,"
Computers and Fluids,
29(8):849-875, 2000.
\endverbatim
diff --git a/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H b/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
index a775d91..9131558 100644
--- a/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
+++ b/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
@@ -131,11 +131,11 @@ public:
//- the dragfunction K used in the momentum eq.
// ddt(alpha*rhoa*Ua) + ... = ... alpha*beta*K*(Ua-Ub)
// ddt(beta*rhob*Ub) + ... = ... alpha*beta*K*(Ub-Ua)
- // **********************************�NB ! *****************************
- // for numerical reasons alpha and beta has been
- // extracted from the dragFunction K,
- // so you MUST divide K by alpha*beta when implemnting the drag function
- // **********************************�NB ! *****************************
+ // ********************************** NB ! *****************************
+ // for numerical reasons alpha and beta has been extracted from the
+ // dragFunction K, so you MUST divide K by alpha*beta when implementing
+ // the drag function
+ // ********************************** NB ! *****************************
virtual tmp<volScalarField> K(const volScalarField& Ur) const = 0;
};
diff --git a/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H b/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H
index e4871f2..ad5de57 100644
--- a/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H
+++ b/applications/solvers/multiphase/multiphaseEulerFoam/interfacialModels/heatTransferModels/heatTransferModel/heatTransferModel.H
@@ -114,12 +114,11 @@ public:
//- the heat-transfer function K used in the enthalpy eq.
// ddt(alpha*rhoa*ha) + ... = ... alpha*beta*K*(Ta - Tb)
// ddt(beta*rhob*hb) + ... = ... alpha*beta*K*(Tb - Ta)
- // **********************************�NB ! *****************************
- // for numerical reasons alpha and beta has been
- // extracted from the heat-transfer function K,
- // so you MUST divide K by alpha*beta when implementing the
- // heat-transfer function
- // **********************************�NB ! *****************************
+ // ********************************** NB ! *****************************
+ // for numerical reasons alpha and beta has been extracted from the
+ // heat-transfer function K, so you MUST divide K by alpha*beta when
+ // implementing the heat-transfer function
+ // ********************************** NB ! *****************************
virtual tmp<volScalarField> K(const volScalarField& Ur) const = 0;
};
diff --git a/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H b/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
index 237c7cf..e96a9a8 100644
--- a/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
+++ b/applications/solvers/multiphase/twoPhaseEulerFoam/interfacialModels/dragModels/dragModel/dragModel.H
@@ -114,11 +114,11 @@ public:
//- the dragfunction K used in the momentum eq.
// ddt(alpha*rhoa*Ua) + ... = ... alpha*beta*K*(Ua-Ub)
// ddt(beta*rhob*Ub) + ... = ... alpha*beta*K*(Ub-Ua)
- // **********************************�NB ! *****************************
- // for numerical reasons alpha and beta has been
- // extracted from the dragFunction K,
- // so you MUST divide K by alpha*beta when implemnting the drag function
- // **********************************�NB ! *****************************
+ // ********************************** NB ! *****************************
+ // for numerical reasons alpha and beta has been extracted from the
+ // dragFunction K, so you MUST divide K by alpha*beta when implementing
+ // the drag function
+ // ********************************** NB ! *****************************
virtual tmp<volScalarField> K(const volScalarField& Ur) const = 0;
};
diff --git a/src/lagrangian/molecularDynamics/molecule/reducedUnits/reducedUnits.H b/src/lagrangian/molecularDynamics/molecule/reducedUnits/reducedUnits.H
index 632e5d3..330bca1 100644
--- a/src/lagrangian/molecularDynamics/molecule/reducedUnits/reducedUnits.H
+++ b/src/lagrangian/molecularDynamics/molecule/reducedUnits/reducedUnits.H
@@ -104,7 +104,7 @@ public:
//- Construct with no argument, uses default values:
// length = 1nm
- // mass = 1.660538782eâ27kg (unified atomic mass unit)
+ // mass = 1.660538782e-27kg (unified atomic mass unit)
// temperature = 1K (therefore, energy = 1*kb)
reducedUnits();
diff --git a/src/lagrangian/molecularDynamics/old/reducedUnits/reducedUnits.H b/src/lagrangian/molecularDynamics/old/reducedUnits/reducedUnits.H
index 632e5d3..330bca1 100644
--- a/src/lagrangian/molecularDynamics/old/reducedUnits/reducedUnits.H
+++ b/src/lagrangian/molecularDynamics/old/reducedUnits/reducedUnits.H
@@ -104,7 +104,7 @@ public:
//- Construct with no argument, uses default values:
// length = 1nm
- // mass = 1.660538782eâ27kg (unified atomic mass unit)
+ // mass = 1.660538782e-27kg (unified atomic mass unit)
// temperature = 1K (therefore, energy = 1*kb)
reducedUnits();
diff --git a/src/turbulenceModels/compressible/RAS/SpalartAllmaras/SpalartAllmaras.H b/src/turbulenceModels/compressible/RAS/SpalartAllmaras/SpalartAllmaras.H
index 9faed12..3ed218e 100644
--- a/src/turbulenceModels/compressible/RAS/SpalartAllmaras/SpalartAllmaras.H
+++ b/src/turbulenceModels/compressible/RAS/SpalartAllmaras/SpalartAllmaras.H
@@ -33,7 +33,7 @@ Description
"A One-Equation Turbulence Model for Aerodynamic Flows"
P.R. Spalart,
S.R. Allmaras,
- La Recherche A´rospatiale, No. 1, 1994, pp. 5–21.
+ La Recherche Aerospatiale, No. 1, 1994, pp. 5--21.
Extended according to:
diff --git a/src/turbulenceModels/incompressible/RAS/SpalartAllmaras/SpalartAllmaras.H b/src/turbulenceModels/incompressible/RAS/SpalartAllmaras/SpalartAllmaras.H
index f310478..50d3184 100644
--- a/src/turbulenceModels/incompressible/RAS/SpalartAllmaras/SpalartAllmaras.H
+++ b/src/turbulenceModels/incompressible/RAS/SpalartAllmaras/SpalartAllmaras.H
@@ -33,7 +33,7 @@ Description
"A One-Equation Turbulence Model for Aerodynamic Flows"
P.R. Spalart,
S.R. Allmaras,
- La Recherche A´rospatiale, No. 1, 1994, pp. 5–21.
+ La Recherche Aerospatiale, No. 1, 1994, pp. 5--21.
Extended according to:
--
1.7.5.4
|
|
|
Thanks for the bug-report. Using find . -name "*.[HC]" -exec grep -P "[\x80-\xFF]" {} \; -print all files flaged have now been corrected in commit 84e40399c59b471de9a7e5b11bebf6a96af7c10e |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-18 21:04 |
|
New Issue | |
| 2012-01-18 21:04 |
|
File Added: 0001-STYLE-Invalid-encoding-and-typos-in-comments-in-drag.patch | |
| 2012-01-19 07:56 |
|
Note Added: 0000934 | |
| 2012-01-19 07:57 |
|
File Added: 0001-STYLE-Non-ascii-characters-and-typos-in-comments.patch | |
| 2012-01-20 10:58 | henry | Note Added: 0000940 | |
| 2012-01-20 10:58 | henry | Status | new => resolved |
| 2012-01-20 10:58 | henry | Resolution | open => fixed |
| 2012-01-20 10:58 | henry | Assigned To | => henry |
