View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003886 | OpenFOAM | Patch | public | 2022-09-15 20:25 | 2022-09-16 10:00 |
| Reporter | cgoessni | Assigned To | henry | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | unable to reproduce | ||
| Platform | amd64 | OS | CentOS | OS Version | 7 |
| Product Version | dev | ||||
| Summary | 0003886: tutorial cases: add $FOAM_CASE to #include | ||||
| Description | Thank you for adding -case to foamDictionary. With this new option enabled, my OpenFOAM config parser script showed that two current tutorial cases need a minor update #include "./include/..." => #include "FOAM_CASE/include/.." Additionally, there seems to be an invalid dictionary present in an old tutorial case for foamyHexMesh and the includes in this tutorial throw an error. A patch which should correct these issues is attached. | ||||
| Tags | No tags attached. | ||||
|
|
of_diff_tut_dicts.txt (4,251 bytes)
diff --git a/tutorials/mesh/foamyHexMesh/flange/system/faceSetDict b/tutorials/mesh/foamyHexMesh/flange/system/faceSetDict
deleted file mode 100644
index 994ed66..0000000
--- a/tutorials/mesh/foamyHexMesh/flange/system/faceSetDict
+++ /dev/null
@@ -1,34 +0,0 @@
-/*--------------------------------*- C++ -*----------------------------------*\
- ========= |
- \\ / F ield | OpenFOAM: The Open Source CFD Toolbox
- \\ / O peration | Website: https://openfoam.org
- \\ / A nd | Version: dev
- \\/ M anipulation |
-\*---------------------------------------------------------------------------*/
-FoamFile
-{
- format ascii;
- class dictionary;
- object faceSetDict;
-}
-
-// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //
-
-// Name of set to operate on
-name facesToBeRemoved;
-
-// One of clear/new/invert/add/delete|subset/list
-action new;
-
-// Actions to apply to pointSet. These are all the topoSetSource's ending
-// in ..ToFace (see the meshTools library).
-topoSetSources
-(
- // Select by explicitly providing face labels
- labelToFace
- {
- value #include "../facesToBeRemoved";
- }
-);
-
-// ************************************************************************* //
diff --git a/tutorials/mesh/foamyHexMesh/flange/system/snappyHexMeshDict b/tutorials/mesh/foamyHexMesh/flange/system/snappyHexMeshDict
index 2a738d4..23e77ad 100644
--- a/tutorials/mesh/foamyHexMesh/flange/system/snappyHexMeshDict
+++ b/tutorials/mesh/foamyHexMesh/flange/system/snappyHexMeshDict
@@ -35,7 +35,7 @@ foamyHexMesh
// - to 'snap' the mesh boundary to the surface
geometry
{
- ${:foamyHexMesh.geometry};
+ $../foamyHexMesh/geometry;
}
@@ -139,7 +139,7 @@ castellatedMeshControls
// section reachable from the insidePoint is kept.
// NOTE: This point should never be on a face, always inside a cell, even
// after refinement.
- insidePoint ${:foamyHexMesh.surfaceConformation.insidePoint};
+ insidePoint $../foamyHexMesh/surfaceConformation/insidePoint;
// Whether any faceZones (as specified in the refinementSurfaces)
diff --git a/tutorials/modules/CHT/circuitBoardCooling/system/fluid/createBafflesDict b/tutorials/modules/CHT/circuitBoardCooling/system/fluid/createBafflesDict
index 0259e3e..454abb4 100644
--- a/tutorials/modules/CHT/circuitBoardCooling/system/fluid/createBafflesDict
+++ b/tutorials/modules/CHT/circuitBoardCooling/system/fluid/createBafflesDict
@@ -33,7 +33,7 @@ baffles
patchFields
{
- #include "./include/wallPatchFields"
+ #include "$FOAM_CASE/include/wallPatchFields"
T
{
@@ -76,7 +76,7 @@ baffles
patchFields
{
- #include "./include/wallPatchFields"
+ #include "$FOAM_CASE/include/wallPatchFields"
T
{
diff --git a/tutorials/modules/fluid/circuitBoardCooling/system/createBafflesDict b/tutorials/modules/fluid/circuitBoardCooling/system/createBafflesDict
index ed082c6..49cecc2 100644
--- a/tutorials/modules/fluid/circuitBoardCooling/system/createBafflesDict
+++ b/tutorials/modules/fluid/circuitBoardCooling/system/createBafflesDict
@@ -33,7 +33,7 @@ baffles
patchFields
{
- #include "./include/wallBafflePatches"
+ #include "$FOAM_CASE/include/wallBafflePatches"
T
{
@@ -76,7 +76,7 @@ baffles
patchFields
{
- #include "./include/wallBafflePatches"
+ #include "$FOAM_CASE/include/wallBafflePatches"
T
{
@@ -102,7 +102,7 @@ baffles
patchFields
{
- #include "./include/wallBafflePatches"
+ #include "$FOAM_CASE/include/wallBafflePatches"
T
{
@@ -139,7 +139,7 @@ baffles
patchFields
{
- #include "./include/wallBafflePatches"
+ #include "$FOAM_CASE/include/wallBafflePatches"
T
{
|
|
|
I do not see a need for #include "./include/..." => #include "FOAM_CASE/include/.." the cases run fine as they do not use foamDictionary and I only changed foamDictionary. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-09-15 20:25 | cgoessni | New Issue | |
| 2022-09-15 20:25 | cgoessni | File Added: of_diff_tut_dicts.txt | |
| 2022-09-15 21:07 | henry | Note Added: 0012737 | |
| 2022-09-16 10:00 | henry | Assigned To | => henry |
| 2022-09-16 10:00 | henry | Status | new => closed |
| 2022-09-16 10:00 | henry | Resolution | open => unable to reproduce |
