View Issue Details

IDProjectCategoryView StatusLast Update
0003754OpenFOAMContributionpublic2021-11-20 21:04
Reporterthf5000y2kAssigned Tohenry 
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSUbuntuOS Version20.04
Product Versiondev 
Fixed in Version 
Summary0003754: Rudundent expression in blockMesh causes performance lost
DescriptionThere's redundent expression in "/applications/utilities/mesh/generation/blockMesh/blockMesh.C". It leads a recomputation for blockMesh's cells, which could be avoid.
https://github.com/OpenFOAM/OpenFOAM-dev/blob/master/applications/utilities/mesh/generation/blockMesh/blockMesh.C
- line276 const List<FixedList<label, 8>> blockCells = b.cells();
- line305 celli += b.cells().size();
The b.cells() in line 305 is same as that in line 276. It can be fixed by the statements below.
- line276 const List<FixedList<label, 8>> blockCells = b.cells();
- line305 celli += blockCells.size();
Steps To ReproduceJust look up the source code, then can easily find out.
https://github.com/OpenFOAM/OpenFOAM-dev/blob/master/applications/utilities/mesh/generation/blockMesh/blockMesh.C
TagsNo tags attached.

Activities

henry

2021-11-20 21:04

manager   ~0012269

Resolved by commit c9b4fc75d4246f877d63d91f1bec504b71d26e7f

Issue History

Date Modified Username Field Change
2021-11-20 14:36 thf5000y2k New Issue
2021-11-20 21:04 henry Assigned To => henry
2021-11-20 21:04 henry Status new => resolved
2021-11-20 21:04 henry Resolution open => fixed
2021-11-20 21:04 henry Note Added: 0012269