View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003700||OpenFOAM||Feature||public||2021-07-28 12:57||2021-07-28 19:16|
|Fixed in Version|
|Summary||0003700: A small modification of the look-up for the chemistry method could enable a smooth integration of custom developed models.|
|Description||The current selection of the chemistry method limits the available options to "standard" or "TDAC". The look-up procedure is rather complicated by checking if the method is "TDAC" and passing a word based on the boolean value.|
const word methodName
This look-up prevents any alternative chemistry methods (e.g. load balancing, etc.) from being used within the OF framework. Using alternative chemistry methods requires either modifications to the "basicChemistryModelNew.C" or lots of code duplication as a work around.
Simplifying the look-up of the "method" to:
const word methodName
could solve this issue, while sill ensuring proper error handling if a non-existen chemistry model is chosen (a modified version of the basicChemistryModelNew.C is attached).
To allow more flexibility to the developments also the chemistry reduction and tabulation could be templated to enable them for custom chemistry models - I have not done this so far, but could provide the files if requested.
|Steps To Reproduce||N/A|
|Tags||No tags attached.|
basicChemistryModelNew.C (6,818 bytes)
The change you propose is not compatible with the generalisation of the chemistry implementation we are currently working on. If you would like to get involved in OpenFOAM core development and maintenance see
Creating a specialised load-balancing implementation just for chemistry is not appropriate for OpenFOAM given the number of different parts of the code which would benefit from load-balancing and the limited maintenance funding we receive; we need a single general implementation to avoid unnecessary maintenance overhead. If you would like to get involved in a general load-balancing implementation please contact us directly.
|2021-07-28 12:57||mboesi||New Issue|
|2021-07-28 12:57||mboesi||File Added: basicChemistryModelNew.C|
|2021-07-28 19:16||henry||Assigned To||=> henry|
|2021-07-28 19:16||henry||Status||new => closed|
|2021-07-28 19:16||henry||Resolution||open => suspended|
|2021-07-28 19:16||henry||Note Added: 0012116|