View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003680 | OpenFOAM | Bug | public | 2021-05-24 12:01 | 2021-05-24 12:28 |
| Reporter | tniemi | Assigned To | henry | ||
| Priority | low | Severity | trivial | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0003680: variableTimeStep_ leftover in TDAC | ||||
| Description | The variableTimeStep-flag was removed in this commit: https://github.com/OpenFOAM/OpenFOAM-dev/commit/672afc917d45b8c1540a3943182c6aa3705bed9c However, there is still bool variableTimeStep_ in TDACChemistryModel.H which is not used anywhere anymore and could be removed. Related to TDACChemistryModel, currently all of its internal variables are set as private, which makes it difficult to inherit from it. Would it be possible to mark the member variables as protected similarly as in standardChemistryModel? | ||||
| Tags | No tags attached. | ||||
