View Issue Details

IDProjectCategoryView StatusLast Update
0003680OpenFOAMBugpublic2021-05-24 12:28
ReportertniemiAssigned Tohenry 
PrioritylowSeveritytrivialReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0003680: variableTimeStep_ leftover in TDAC
DescriptionThe variableTimeStep-flag was removed in this commit:

https://github.com/OpenFOAM/OpenFOAM-dev/commit/672afc917d45b8c1540a3943182c6aa3705bed9c

However, there is still bool variableTimeStep_ in TDACChemistryModel.H which is not used anywhere anymore and could be removed.

Related to TDACChemistryModel, currently all of its internal variables are set as private, which makes it difficult to inherit from it. Would it be possible to mark the member variables as protected similarly as in standardChemistryModel?
TagsNo tags attached.

Activities

henry

2021-05-24 12:28

manager   ~0012043

Resolved by commit e99737fd1b8af95ffe39e372f2621fb502f6b23f

Issue History

Date Modified Username Field Change
2021-05-24 12:01 tniemi New Issue
2021-05-24 12:28 henry Assigned To => henry
2021-05-24 12:28 henry Status new => resolved
2021-05-24 12:28 henry Resolution open => fixed
2021-05-24 12:28 henry Fixed in Version => dev
2021-05-24 12:28 henry Note Added: 0012043