View Issue Details

IDProjectCategoryView StatusLast Update
0003647OpenFOAMPatchpublic2021-03-24 11:11
ReporterJuhoAssigned Towill 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSOtherOS Version(please specify)
Product Versiondev 
Fixed in Versiondev 
Summary0003647: multiphaseEulerFoam: linearTsub diameterModel does not find the saturationModels
DescriptionlinearTsub diameterModel still has the old style global saturation model lookup instead of the phase pair specific saturation models used currently. Thus, the saturationModel is not found and diameter is not updated during the simulations.

Modified linearTsubDiameter attached. Changes:
- Updated to use the current phase pair specific saturation models.
- Changed subcooling sign convention to to be compatible with the default parameters
- Added default values to the read function as well
- Print selected parameters to log
TagsNo tags attached.

Activities

Juho

2021-03-24 08:48

reporter  

linearTsubDiameter.C (4,884 bytes)

will

2021-03-24 09:20

manager   ~0011951

Thanks for the patch, Juho. Small suggestion. Is it possible to use the phase system's lookup instead? It would save doing the name manipulations manually. E.g.:

    if (phase().fluid().foundSubModel<saturationModel>(pair))
    {
        const saturationModel& satModel =
            phase().fluid().lookupSubModel<saturationModel>(pair);

        ...
    }

I'd try it myself, but I don't have a test case with this model active. I assume you do.

Juho

2021-03-24 09:43

reporter   ~0011952

Updated file attached. Much neater this way.

linearTsubDiameter-2.C (4,684 bytes)

will

2021-03-24 11:11

manager   ~0011953

Thanks for that. Pushed as commit https://github.com/OpenFOAM/OpenFOAM-dev/commit/42a558a1b0596896a244ce0489545421aa6260bf

Issue History

Date Modified Username Field Change
2021-03-24 08:48 Juho New Issue
2021-03-24 08:48 Juho File Added: linearTsubDiameter.C
2021-03-24 09:20 will Note Added: 0011951
2021-03-24 09:43 Juho File Added: linearTsubDiameter-2.C
2021-03-24 09:43 Juho Note Added: 0011952
2021-03-24 11:11 will Assigned To => will
2021-03-24 11:11 will Status new => resolved
2021-03-24 11:11 will Resolution open => fixed
2021-03-24 11:11 will Fixed in Version => dev
2021-03-24 11:11 will Note Added: 0011953