View Issue Details

IDProjectCategoryView StatusLast Update
0003631OpenFOAMBugpublic2021-02-17 15:19
ReportertniemiAssigned Tohenry 
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0003631: Damping fvOptions, selectionMode not working?
DescriptionI was reading through the recent changes to fvOptions and happened to notice that while the damping fvOptions are derived from cellSetOption and supposedly can act only on a certain selection, they don't seem to contain any code handling the situation where not all cells are chosen. For example, there is no forAll(cells(), ... loop like in some other fvOptions derived from cellSetOption.

To double check, I took the wave tutorial and made a cellSet with 0 cells and pointed the damping to that set, but it did not change the results compared to "selectionMode all".

I have not personally used these options and I'm not sure what would be the best fix. A simple fix might be to modify the add-functions to only operate on cells within the cells()-list.

Other misc notes:

Documentation for addSup-fuctions refer to momentum equation, although these are for enthalpy equation
https://github.com/OpenFOAM/OpenFOAM-dev/blob/master/src/fvOptions/sources/derived/buoyancyEnergy/buoyancyEnergy.H
https://github.com/OpenFOAM/OpenFOAM-dev/blob/master/src/radiationModels/fvOptions/radiation/radiation.H
TagsNo tags attached.

Activities

tniemi

2021-02-17 12:25

reporter   ~0011887

To add: by damping fvOptions I'm referring to is
https://github.com/OpenFOAM/OpenFOAM-dev/blob/master/src/fvOptions/sources/derived/damping/isotropicDamping/isotropicDamping.H

and the wave tutorial is
https://github.com/OpenFOAM/OpenFOAM-dev/blob/master/tutorials/multiphase/interFoam/laminar/wave/

henry

2021-02-17 12:41

manager   ~0011888

The simplest fix would be to not derive from cellSetOption.

tniemi

2021-02-17 12:48

reporter   ~0011889

Yes, that is true. I would also guess that by using suitable non-uniform scale, it should be possible to emulate localized damping.

henry

2021-02-17 15:19

manager   ~0011890

Resolved by commit a24e8e463ad0703b695295da9f4b222a9cc0d21b

Issue History

Date Modified Username Field Change
2021-02-17 12:22 tniemi New Issue
2021-02-17 12:25 tniemi Note Added: 0011887
2021-02-17 12:41 henry Note Added: 0011888
2021-02-17 12:48 tniemi Note Added: 0011889
2021-02-17 15:19 henry Assigned To => henry
2021-02-17 15:19 henry Status new => resolved
2021-02-17 15:19 henry Resolution open => fixed
2021-02-17 15:19 henry Fixed in Version => dev
2021-02-17 15:19 henry Note Added: 0011890