View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003627 | OpenFOAM | Bug | public | 2021-02-12 08:52 | 2021-02-12 11:08 |
| Reporter | deo | Assigned To | will | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | RHEL | OS Version | 8.3 |
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0003627: Default value of C1 in Prince & Blanch model is wrong | ||||
| Description | The default value for C1 in applications/solvers/multiphase/multiphaseEulerFoam/phaseSystems/populationBalanceModel/coalescenceModels/PrinceBlanch/PrinceBlanch.C is 0.356. However, the default value in the header file is said to be 0.089. Looking at the Prince & Blanch (1990) paper, the value should be 0.089. In the two tutorial cases which use the Prince & Blanch model (wallBoilingPolydisperse and wallBoilingPolydisperseTwoGroups), the value for C1 is set to 0.1, such that the default value is not used. | ||||
| Steps To Reproduce | n/a | ||||
| Tags | No tags attached. | ||||
|
|
Thanks for reporting. It is only the code documentation that is wrong. Equation 2 in the paper contains an error. It should use the diameter rather than the radius for computing the collision cross-section. This error extends to equation 8, where the coefficient that is also referred to in the header is off by a factor of 4. The documentation is updated in the attached patch, the implementation should be correct. The tutorials are ok too by extension. |
|
|
Thanks for the patch, Ronald. Resolved in dev by: https://github.com/OpenFOAM/OpenFOAM-dev/commit/d57401c5af362056f829d893612cc7c040dc2315 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-02-12 08:52 | deo | New Issue | |
| 2021-02-12 10:05 | oertel59 | File Added: 0001-Corrected-header-documentation-of-PrinceBlanch-coale.patch.tar.gz | |
| 2021-02-12 10:05 | oertel59 | Note Added: 0011877 | |
| 2021-02-12 11:08 | will | Assigned To | => will |
| 2021-02-12 11:08 | will | Status | new => resolved |
| 2021-02-12 11:08 | will | Resolution | open => fixed |
| 2021-02-12 11:08 | will | Fixed in Version | => dev |
| 2021-02-12 11:08 | will | Note Added: 0011878 |
