View Issue Details

IDProjectCategoryView StatusLast Update
0003594OpenFOAMPatchpublic2020-11-23 14:55
ReporterrguttAssigned Tohenry 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSUbuntuOS Version20.04
Product Version7 
Fixed in Versiondev 
Summary0003594: alphaEqh wrong order
DescriptionI think alpha2 should be calculated after alpha1 was corrected. Otherwise, the sum of alpha1 + alpha2 might not be equals to 1, if alpha1 has some correction coming from the contact angle.


Line code
225 alpha2 = 1.0 - alpha1;
226
227 mixture.correct();
Additional InformationFile: Solvers/multiphase/VoF/alphaEqn.H
TagsNo tags attached.

Activities

henry

2020-11-16 14:13

manager   ~0011687

The mixture.correct() might use alpha2 (currently it doesn't but perhaps it should be written that way) so it would have to be updated before and after the mixture.correct(), but it would probably be better if it updated alpha2 after updating alpha1.

henry

2020-11-23 14:55

manager   ~0011744

Resolved by commit 92c9b112f005f02cd32dbbfbe03671dda7c3959c

Issue History

Date Modified Username Field Change
2020-11-16 13:32 rgutt New Issue
2020-11-16 14:13 henry Note Added: 0011687
2020-11-23 14:55 henry Assigned To => henry
2020-11-23 14:55 henry Status new => resolved
2020-11-23 14:55 henry Resolution open => fixed
2020-11-23 14:55 henry Fixed in Version => dev
2020-11-23 14:55 henry Note Added: 0011744