View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003467||OpenFOAM||Contribution||public||2020-03-17 11:52||2020-03-17 20:28|
|Reporter||Tom van den Brink||Assigned To||henry|
|Status||closed||Resolution||no change required|
|Fixed in Version|
|Summary||0003467: Addition of viscoelasticFluidFoam solver|
For a project I needed viscoelasticFluidFoam to work so I patched it from ext4.1 to the current dev tree. All seems to be working fine so far and I can run solutions on it now.
Corrected the solver, transportmodels and all tutorials (except 1 blockmesh that i still have to work on) to properly compile and run without errors in dev.
Info can be found in my github with the development branch. https://github.com/tomracing79/OpenFOAM-dev/tree/viscoelasticFoam
I would like to do a pull request in the end when I've updated master and finished a succesfull branch merge but would like feedback before I do so.
Also a question about what to do with the headers in the files and how to attribute the work to the original authors?
|Tags||No tags attached.|
Viscoelasticity in OpenFOAM does not need a special solver, it is handled within the TurbulenceModels framework as a special laminar sub-set so that it can be used in any single-phase, multiphase, incompressible or compressible solver. Currently Maxwell, Giesekus and PTT models are supported in both single mode and multi-mode operation and other models can easily be added.
thank you for pointing this out. Sorry I hadn't noticed this improvement was there already. In any case it was an interesting exercise in C++ debugging.
I will first compare the results to see if they are identical and then try implementing some other models.
Would that be of interest to contribute in the end?
||Which other models are needed for which fluids?|
||Viscoelasticity is already supported in a more general manner in OpenFOAM.|
|2020-03-17 11:52||Tom van den Brink||New Issue|
|2020-03-17 12:03||henry||Note Added: 0011251|
|2020-03-17 12:03||henry||Note Edited: 0011251||View Revisions|
|2020-03-17 15:51||Tom van den Brink||Note Added: 0011252|
|2020-03-17 16:19||henry||Note Added: 0011253|
|2020-03-17 20:28||henry||Assigned To||=> henry|
|2020-03-17 20:28||henry||Status||new => closed|
|2020-03-17 20:28||henry||Resolution||open => no change required|
|2020-03-17 20:28||henry||Note Added: 0011254|