View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003435 | OpenFOAM | Bug | public | 2020-01-24 08:53 | 2020-01-24 14:41 |
| Reporter | user136 | Assigned To | henry | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | HPC-Cluster | OS | CentOS | OS Version | unknown |
| Fixed in Version | dev | ||||
| Summary | 0003435: refineWallLayer: Option "-useSet" works not correctly | ||||
| Description | Hi all, when using refineWallLayer, the option "-useSet" should restrict the refinement to a certain cellSet. But, instead it does the opposite: Cells in the cellSet are not refined, but all the others. I see this on OF4.1, but since refineWallLayer didn't change much it should be same on OF7. The reason is obvious in the source code: the cellSet cells are erased from the set of cells "cutCells"which are to be cut: cellSet cells(mesh, setName); forAllConstIter(cellSet, cells, iter) { cutCells.erase(iter.key()); } Best regards, Carsten | ||||
| Steps To Reproduce | - Unpack zipfile - Run: blockMesh setSet -batch setSet.batch refineWallLayer -useSet c0 '(zmin)' 0.3 Look at the wall layers: They should be in cells with (0 < x < 0.5), (0 < y < 0.5), (z=0), bit instead they aree outside. | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
On further review of the code I agree with your assessment, the documentation is ambiguous, the Info statement is confusing and the operation the opposite of that expected. I will correct the code. |
|
|
Try commit d7a452ccf2948827f4164919f19fb152bd0e0f6c (HEAD -> master, origin/master, origin/HEAD) Author: Henry Weller <http://openfoam.org> Date: Fri Jan 24 10:39:58 2020 +0000 refineWallLayer: Changed name of the -useSet option to -inSet, corrected operation and documentation Resolves bug-report https://bugs.openfoam.org/view.php?id=3435 |
|
|
Works as expected now. Best regards, Carsten |
|
|
Resolved by commit d7a452ccf2948827f4164919f19fb152bd0e0f6c |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-01-24 08:53 | user136 | New Issue | |
| 2020-01-24 08:53 | user136 | File Added: refineWallLayerTest.zip | |
| 2020-01-24 09:59 | henry | Note Added: 0011101 | |
| 2020-01-24 10:42 | henry | Note Added: 0011102 | |
| 2020-01-24 12:08 | user136 | Note Added: 0011104 | |
| 2020-01-24 14:41 | henry | Assigned To | => henry |
| 2020-01-24 14:41 | henry | Status | new => resolved |
| 2020-01-24 14:41 | henry | Resolution | open => fixed |
| 2020-01-24 14:41 | henry | Fixed in Version | => dev |
| 2020-01-24 14:41 | henry | Note Added: 0011105 |
