View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003381 | OpenFOAM | Patch | public | 2019-11-10 13:55 | 2019-12-28 17:41 |
| Reporter | handrake0724 | Assigned To | henry | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | suspended | ||
| Product Version | dev | ||||
| Summary | 0003381: additional function1 functions | ||||
| Description | In addition to current Function1s, I think it is nice to have frequently used functions such as exponential, squared cosine/sine. I have made a code. please review if it is useful. | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
Have you based this implementation on the latest Function1 functions? In order that these functions are generally useful integrate in needed, also it is better that scaling is applied externally to support this, see the latest Sine implementation. commit dcf4d0c505255c0516ce85c14648aaaf0be9a444 Author: Will Bainbridge <http://cfd.direct> Date: Thu Oct 17 19:11:05 2019 +0100 Function1: Implemented integral evaluations Integral evaluations have been implemented for all the ramp function1-s, as well as the sine and square wave. Bounds handling has also been added to the integration of table-type functions. In addition, the sine wave "t0" paramater has been renamed "start" for consistency with the ramp functions. |
|
|
I did not catch up the recent changes. I will check it. |
|
|
code based on the latest of OpenFOAM-dev is attached. please review. |
|
|
Do you have a particular use-case for these functions? It might be useful to include them in a tutorial. We have not needed them and they have never been requested. |
|
|
If there is a need for a lot more Function1 forms, particularly is combinations of functions are needed other than simple multiplication perhaps it would be better to implement a codedFunction1 like codedFixedValueFvPatchField. |
|
|
Orphaned report. Please re-open if these additional functions are still required and provide example cases which can be used as tutorials to demonstrate and test the implementation. Alternatively if other more general functions or combination of functions are required it would be better to implement a codedFunction1. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-11-10 13:55 | handrake0724 | New Issue | |
| 2019-11-10 13:55 | handrake0724 | File Added: function1s.tar.gz | |
| 2019-11-10 14:21 | henry | Note Added: 0010872 | |
| 2019-11-10 16:27 | handrake0724 | Note Added: 0010873 | |
| 2019-11-10 17:00 | handrake0724 | File Added: function1s-dev.tar.gz | |
| 2019-11-10 17:00 | handrake0724 | Note Added: 0010874 | |
| 2019-11-10 17:24 | henry | Note Added: 0010875 | |
| 2019-11-12 11:40 | henry | Note Added: 0010887 | |
| 2019-11-20 11:46 | henry | Assigned To | => henry |
| 2019-11-20 11:46 | henry | Status | new => closed |
| 2019-11-20 11:46 | henry | Resolution | open => suspended |
| 2019-11-20 11:46 | henry | Note Added: 0010923 |
