0003309: Lagrangian fields cloud scattering coefficient is always zero

ID	Project	Category	View Status	Date Submitted	Last Update

0003309	OpenFOAM	Bug	public	2019-07-19 09:55	2019-07-19 11:52

Reporter	alish1984	Assigned To	will
Priority	normal	Severity	major	Reproducibility	always
Status	resolved	Resolution	fixed
Platform	GNU/Linux	OS	Ubuntu	OS Version	18.04
Fixed in Version	dev

Summary	0003309: Lagrangian fields cloud scattering coefficient is always zero
Description	It seems that when using "cloudScatter" as a scatterModel in radiation modelling, sigmaEff (the scattering of particles) is always zero. The reason: In ThermoParcelI.H where this cloudScatter is computed in sigmap() function: tsigmap is declared and its value is set to zero. Then in the last line before "return" we have: sigmap = sumAreaP(1.0 - f)(1.0 - epsilon)/V/dt; So it is always zero, because it is multiplied by zero. I don't know why multiplication has been used. I think it should be simply: sigmap = sumAreaP(1.0 - f)*(1.0 - epsilon)/V/dt; Honestly, I did not reproduce the bug in OF6 because I don't have the code compiled so I can not simply print the field (currently I am using 2.4.x.). However, the bug is the same in all versions, because the same line of the code has been used in the new versions. Am I correct or I understood it wrongly? You can test it by simply printing the variable while running the tutorial "simplifiedSiwek". I did it for 2.4.x.
Tags	No tags attached.

Date Modified	Username	Field	Change
2019-07-19 09:55	alish1984	New Issue
2019-07-19 11:52	will	Assigned To	=> will
2019-07-19 11:52	will	Status	new => resolved
2019-07-19 11:52	will	Resolution	open => fixed
2019-07-19 11:52	will	Fixed in Version	=> dev
2019-07-19 11:52	will	Note Added: 0010615

will 2019-07-19 11:52 manager ~0010615	You are correct, the implementation is wrong. Thanks for letting us know. Fixed in dev by https://github.com/OpenFOAM/OpenFOAM-dev/commit/7e65281f60923e0c3d3dc545a505f6445760b961.