View Issue Details

IDProjectCategoryView StatusLast Update
0002999OpenFOAM[All Projects] Bugpublic2018-07-12 09:00
ReporterpkieckAssigned Towill 
PrioritynoneSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0002999: Wrong datatype for counting parcels in ThermoCloudI.H
DescriptionThermoCloud::Tmax() and ThermoCloud::Tmin() both count the number of parcels using a scalar n which is then reduced using sumOp<label>.
TagsNo tags attached.

Activities

pkieck

2018-06-29 13:37

reporter  

ThermoCloudTstat.patch (918 bytes)
diff --git a/src/lagrangian/intermediate/clouds/Templates/ThermoCloud/ThermoCloudI.H b/src/lagrangian/intermediate/clouds/Templates/ThermoCloud/ThermoCloudI.H
index ae62a8a..43b997f 100644
--- a/src/lagrangian/intermediate/clouds/Templates/ThermoCloud/ThermoCloudI.H
+++ b/src/lagrangian/intermediate/clouds/Templates/ThermoCloud/ThermoCloudI.H
@@ -373,7 +373,7 @@ template<class CloudType>
 inline Foam::scalar Foam::ThermoCloud<CloudType>::Tmax() const
 {
     scalar T = -great;
-    scalar n = 0;
+    label n = 0;
     forAllConstIter(typename ThermoCloud<CloudType>, *this, iter)
     {
         const parcelType& p = iter();
@@ -399,7 +399,7 @@ template<class CloudType>
 inline Foam::scalar Foam::ThermoCloud<CloudType>::Tmin() const
 {
     scalar T = great;
-    scalar n = 0;
+    label n = 0;
     forAllConstIter(typename ThermoCloud<CloudType>, *this, iter)
     {
         const parcelType& p = iter();

will

2018-07-12 09:00

manager   ~0009850

Resolved in dev by commit 23d523d9

Issue History

Date Modified Username Field Change
2018-06-29 13:37 pkieck New Issue
2018-06-29 13:37 pkieck File Added: ThermoCloudTstat.patch
2018-07-12 09:00 will Assigned To => will
2018-07-12 09:00 will Status new => resolved
2018-07-12 09:00 will Resolution open => fixed
2018-07-12 09:00 will Fixed in Version => dev
2018-07-12 09:00 will Note Added: 0009850