View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002829 | OpenFOAM | Patch | public | 2018-02-07 01:29 | 2018-02-07 15:58 |
| Reporter | handrake0724 | Assigned To | henry | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Platform | x86_64 | OS | Arch | OS Version | (please specify) |
| Fixed in Version | dev | ||||
| Summary | 0002829: directFieldMapper has wrong named constructor | ||||
| Description | I found directFieldMapper class has wrong named constructor as below. I am not sure if this class is in use because the header file is included nowhere. class directFieldMapper : public FieldMapper { const labelUList& directAddressing_; bool hasUnmapped_; public: // Constructors //- Construct given addressing patchFieldSubset(const labelUList& directAddressing) : directAddressing_(directAddressing), hasUnmapped_(false) { if (directAddressing_.size() && min(directAddressing_) < 0) { hasUnmapped_ = true; } } //- Destructor virtual ~directFieldMapper() {} ... } Anyway, I think the constructor should be renamed from patchFieldSubset(const labelUList& directAddressing) to directFieldMapper(const labelUList& directAddressing) | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-02-07 01:29 | handrake0724 | New Issue | |
| 2018-02-07 15:58 | henry | Assigned To | => henry |
| 2018-02-07 15:58 | henry | Status | new => resolved |
| 2018-02-07 15:58 | henry | Resolution | open => fixed |
| 2018-02-07 15:58 | henry | Fixed in Version | => dev |
| 2018-02-07 15:58 | henry | Note Added: 0009276 |
