View Issue Details

IDProjectCategoryView StatusLast Update
0002829OpenFOAMPatchpublic2018-02-07 15:58
Reporterhandrake0724Assigned Tohenry 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Platformx86_64OSArchOS Version(please specify)
Product Version5.x 
Fixed in Versiondev 
Summary0002829: directFieldMapper has wrong named constructor
DescriptionI found directFieldMapper class has wrong named constructor as below.
I am not sure if this class is in use because the header file is included nowhere.

class directFieldMapper
:
    public FieldMapper
{
    const labelUList& directAddressing_;

    bool hasUnmapped_;

public:

    // Constructors

        //- Construct given addressing
        patchFieldSubset(const labelUList& directAddressing)
        :
            directAddressing_(directAddressing),
            hasUnmapped_(false)
        {
            if (directAddressing_.size() && min(directAddressing_) < 0)
            {
                hasUnmapped_ = true;
            }
        }

    //- Destructor
    virtual ~directFieldMapper()
    {}
    ...
}

Anyway, I think the constructor should be renamed
from
    patchFieldSubset(const labelUList& directAddressing)
to
    directFieldMapper(const labelUList& directAddressing)
TagsNo tags attached.

Activities

henry

2018-02-07 15:58

manager   ~0009276

Resolved by commit 8cbde12c80fe8ff7a13aaad8dbc8e7be76e2a894

Issue History

Date Modified Username Field Change
2018-02-07 01:29 handrake0724 New Issue
2018-02-07 15:58 henry Assigned To => henry
2018-02-07 15:58 henry Status new => resolved
2018-02-07 15:58 henry Resolution open => fixed
2018-02-07 15:58 henry Fixed in Version => dev
2018-02-07 15:58 henry Note Added: 0009276