View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002751 | OpenFOAM | Bug | public | 2017-11-07 12:58 | 2017-11-07 13:36 |
| Reporter | bjnieuwboer | Assigned To | henry | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Platform | GNU/Linux | OS | Ubuntu | OS Version | 14.10 |
| Summary | 0002751: Is the computation of Vsc for a moving mesh correct? | ||||
| Description | Vsc is computed in fvMeshGeometry.C. For a moving mesh it differs from the usual cell volume and uses a fractional time to correct it. For an constant (fluid)time step, this fractional time step changes from 1 to 2, while there is an if-statement which is executed when the fractional time is smaller than 1. This is never the case. In the computation of Vsc0 the fractional time is between 0 and 1. This looks more like a correct behaviour. I don't really get what the Vsc does over the usual V-method. So I cannot state why this is an error and what should be done to change it. However, it does look like one. | ||||
| Steps To Reproduce | Look in fvMeshGeometry.C from line 275. | ||||
| Tags | No tags attached. | ||||
|
|
Can you provide a test-case which shows the problem? |
|
|
Sorry, I don't have a test case which shows the problem. I have to admit that I don't completely understand what this part of the code does. However, when you look at the member function (lines 275 to 300) in fvMeshGeometry.C, you can see something illogical is happening. First, you would expect a fractional time to be between 0 and 1. This is also the behaviour in the VscO member fucntion. Secondly there is an if statement which is never executed. The combination of those two is for me a strong indication that something is wrong. Could you take a (quick) look at that function to see if there is some truth in my statement? |
|
|
For me the code runs correctly, tFrac is calculated correctly and the if statement executes correctly. If you believe there is a problem you will need to provide a case which demonstrates it. |
|
|
Please reopen if you can provide a case which demonstrates the issue. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-11-07 12:58 | bjnieuwboer | New Issue | |
| 2017-11-07 13:23 | henry | Note Added: 0009007 | |
| 2017-11-07 13:33 | bjnieuwboer | Note Added: 0009008 | |
| 2017-11-07 13:33 | henry | Note Edited: 0009007 | |
| 2017-11-07 13:35 | henry | Note Added: 0009009 | |
| 2017-11-07 13:36 | henry | Assigned To | => henry |
| 2017-11-07 13:36 | henry | Status | new => closed |
| 2017-11-07 13:36 | henry | Resolution | open => no change required |
| 2017-11-07 13:36 | henry | Note Added: 0009010 |
