View Issue Details

IDProjectCategoryView StatusLast Update
0002716OpenFOAM[All Projects] Bugpublic2017-10-09 12:24
ReporterShortyAssigned Tohenry 
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Fixed in Versiondev 
Summary0002716: Tiny error in PCG.C
DescriptionHi all,

I just want to let you know that there is a tiny error in the PCG.C. If one specifies 100 maximum iterations for the solver, the PCG solver always uses one iteration more. The code line 185 can be changed as follows:

============================================
solverPerf.nIterations()++ < maxIter_
============================================

Should be:

============================================
++solverPerf.nIterations() < maxIter_
============================================


Zappo from CFD-online posted that tiny error and I thought that it is worth to mention. Corresponding thread:
https://www.cfd-online.com/Forums/openfoam-bugs/193957-tiny-error-linear-pcg-solver.html#post666844



Have a nice week
Tobi
TagsPCG, Solver

Activities

henry

2017-10-09 12:24

manager   ~0008839

Resolved by commit e1813615393d5997f9bf7021ed7f0fa442d4ac56

Issue History

Date Modified Username Field Change
2017-10-09 09:36 Shorty New Issue
2017-10-09 09:36 Shorty Tag Attached: Solver
2017-10-09 09:36 Shorty Tag Attached: PCG
2017-10-09 12:24 henry Assigned To => henry
2017-10-09 12:24 henry Status new => resolved
2017-10-09 12:24 henry Resolution open => fixed
2017-10-09 12:24 henry Fixed in Version => dev
2017-10-09 12:24 henry Note Added: 0008839