View Issue Details

IDProjectCategoryView StatusLast Update
0002612OpenFOAMBugpublic2017-07-13 08:51
ReporterArne Assigned Towill  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSUbuntuOS Version14.04
Product Versiondev 
Summary0002612: In twoPhaseEulerFoam Ergun drag correlation is calculated wrongly
DescriptionIn the calculation of the ergun drag in twoPhaseEulerFoam (4/3) is multiplied to the drag. This is needed as the general drag gets multiplied with 0.75. In the case of the ergun drag this is not needed and should be neglected by the 4/3. However, at least on my platform 4/3 is an integer division which produces unity. Hence has no influence on the value of the drag. Like this the calculated value is too low.

The problem can be solved by replacing 4/3 with 4.0/3.0
Steps To ReproduceRun any simulation using th Ergun drag modeling
Tagsdrag, multiphase

Activities

will

2017-07-13 08:51

manager   ~0008387

Agreed. Textbook C++ mistake. Thank you for the report.

Resolved by commit 2b05ad16b26a822d9dce1029c97c49291febd99d

Issue History

Date Modified Username Field Change
2017-07-13 08:19 Arne New Issue
2017-07-13 08:19 Arne Tag Attached: drag
2017-07-13 08:19 Arne Tag Attached: execFlowFunctionObjects
2017-07-13 08:19 Arne Tag Attached: multiphase
2017-07-13 08:23 Arne Tag Detached: execFlowFunctionObjects
2017-07-13 08:51 will Assigned To => will
2017-07-13 08:51 will Status new => resolved
2017-07-13 08:51 will Resolution open => fixed
2017-07-13 08:51 will Note Added: 0008387