View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000245 | OpenFOAM | Bug | public | 2011-07-09 03:25 | 2011-07-10 22:12 |
| Reporter | albertop | Assigned To | henry | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | OpenSuse | OS Version | 11.3 |
| Summary | 0000245: Missing p.storePrevIter() in bubbleFoam | ||||
| Description | Storage of the pressure at the previous iteration is not performed in bubbleFoam, causing an error when relaxation is applied with factor smaller than 1. A patch is attached. | ||||
| Tags | No tags attached. | ||||
|
|
bubbleFoam.C.patch (500 bytes)
*** bubbleFoamOld.C 2011-07-08 21:18:50.122684892 -0500
--- bubbleFoam.C 2011-07-08 21:18:59.992662123 -0500
***************
*** 64,69 ****
--- 64,74 ----
// --- Pressure-velocity PIMPLE corrector loop
for (pimple.start(); pimple.loop(); pimple++)
{
+ if (pimple.nOuterCorr() != 1)
+ {
+ p.storePrevIter();
+ }
+
#include "alphaEqn.H"
#include "liftDragCoeffs.H"
#include "UEqns.H"
|
|
|
The same problem affects twoPhaseEulerFoam. A second patch is attached. |
|
|
twoPhaseEulerFoam.C.patch (487 bytes)
*** twoPhaseEulerFoam.C 2011-06-16 14:42:23.858368687 -0500
--- twoPhaseEulerFoamNew.C 2011-07-08 21:27:18.785256024 -0500
***************
*** 78,83 ****
--- 78,88 ----
// --- Pressure-velocity PIMPLE corrector loop
for (pimple.start(); pimple.loop(); pimple++)
{
+ if (pimple.nOuterCorr() != 1)
+ {
+ p.storePrevIter();
+ }
+
#include "alphaEqn.H"
#include "liftDragCoeffs.H"
|
|
|
Thanks for the bug-report and patches. Resolved by commit 8f94b047620af1b3f0fc713a3ed7aeed5e3092c8 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-07-09 03:25 | albertop | New Issue | |
| 2011-07-09 03:25 | albertop | File Added: bubbleFoam.C.patch | |
| 2011-07-09 03:28 | albertop | Note Added: 0000530 | |
| 2011-07-09 03:28 | albertop | File Added: twoPhaseEulerFoam.C.patch | |
| 2011-07-10 22:12 | henry | Note Added: 0000535 | |
| 2011-07-10 22:12 | henry | Status | new => resolved |
| 2011-07-10 22:12 | henry | Resolution | open => fixed |
| 2011-07-10 22:12 | henry | Assigned To | => henry |
