View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002432 | OpenFOAM | Bug | public | 2017-01-14 12:14 | 2017-01-15 18:43 |
| Reporter | AMRBlack | Assigned To | henry | ||
| Priority | high | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Platform | GNU/Linux | OS | Ubuntu | OS Version | 14.10 |
| Summary | 0002432: bug in sutherlandTransport of thermo package | ||||
| Description | While checking the calculation of transport parameters in thermo packages, I found that the impl of "Modified Eucken Models" in sutherlandTransport has one bug. file: ${FOAM_SRC}/thermophysicalModels/specie/transport/sutherland/sutherlandTransportI.H function: sutherlandTransport<Thermo>::kappa(const scalar p, const scalar T) const { >>>>>>>>>>>>>>>>> //origin impl scalar Cv_ = this->Cv(p, T); return mu(p, T)*Cv_*(1.32 + 1.77*this->R()/Cv_); //note: the last past "1.77*this->R()/Cv_" should be dimensionless, but not. <<<<<<<<<<<<<<<<< >>>>>>>>>>>>>>>>> //patched impl: scalar cv_ = this->cv(p, T); scalar Cv_ = cv_/this->W(); return mu(p, T)*Cv_*(1.32 + 1.77*this->R()/cv_); <<<<<<<<<<<<<<<<< } All versions of OpenFOAM are effected by this bug. | ||||
| Additional Information | Ref: THE PROPERTIES OF GASES AND LIQUIDS. Bruce E. Poling. 5th Edition. Section:10-3. | ||||
| Tags | thermo | ||||
|
|
this->R() has the units [J/(kg K)] Cv_ has the units [J/(kg K)] so this->R()/Cv_ is dimensionless. Have you tested your proposed change? As far as I can see it is incorrect and will return incorrect kappa. |
|
|
Thank you and i am so sorry for my mistake. Please close this. |
|
|
In future please test patches before submitting them for inclusion to avoid wasting the precious time of the maintainers OpenFOAM. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-01-14 12:14 | AMRBlack | New Issue | |
| 2017-01-14 12:14 | AMRBlack | Tag Attached: thermo | |
| 2017-01-14 12:25 | henry | Note Added: 0007634 | |
| 2017-01-15 03:44 | AMRBlack | Note Added: 0007635 | |
| 2017-01-15 18:43 | henry | Assigned To | => henry |
| 2017-01-15 18:43 | henry | Status | new => closed |
| 2017-01-15 18:43 | henry | Resolution | open => no change required |
| 2017-01-15 18:43 | henry | Note Added: 0007636 |
