View Issue Details

IDProjectCategoryView StatusLast Update
0002364OpenFOAMFeaturepublic2016-12-01 15:20
ReporterjoegiAssigned Tohenry 
PrioritynormalSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
Product Version 
Fixed in Versiondev 
Summary0002364: Update source code description in src/finiteVolume/finiteVolume/snGradSchemes/
DescriptionI was reading the source code in src/finiteVolume/finiteVolume/snGradSchemes/, and it might be a good idea to update the description of uncorrectedSnGrad.H and orthogonalSnGrad.H

From the current description one may think that both methods use the same implementation. Instead, orthogonalSnGrad uses only the orthogonal contribution and uncorrectedSnGrad uses only the non-orthogonal contribution (if I am not mistaken).
TagsNo tags attached.

Activities

henry

2016-12-01 13:26

manager   ~0007366

Both use only a contribution from the two cells sharing the face but with different 'delta' coefficients. Neither include the non-orthogonal contribution from the surrounding cells.

henry

2016-12-01 15:20

manager   ~0007369

Resolved in OpenFOAM-dev by commit f3bd633dae32094c284fc41ba7bd5c8a4afeb887

Issue History

Date Modified Username Field Change
2016-12-01 13:08 joegi New Issue
2016-12-01 13:26 henry Note Added: 0007366
2016-12-01 15:20 henry Assigned To => henry
2016-12-01 15:20 henry Status new => resolved
2016-12-01 15:20 henry Resolution open => fixed
2016-12-01 15:20 henry Fixed in Version => dev
2016-12-01 15:20 henry Note Added: 0007369