View Issue Details

IDProjectCategoryView StatusLast Update
0002320OpenFOAMBugpublic2016-11-25 17:08
Reporterjoegi Assigned Tohenry  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformopensuse 42.1OSopensuse 42.1OS Versionopensuse 42.1
Summary0002320: yplus functionobject does not show the value on screen
DescriptionIf you use the function object yplus, it does not show the output in the screen.

I don't know if it is the desired behavior but in previous versions the yplus value was printed in the screen and it was possible to use the option log on/off.
Steps To ReproduceAny case where you can use yplus.
So far I have test it only with the komegasst model
TagsNo tags attached.

Relationships

related to 0002353 closedhenry yplus functionobject does not show the value on screen 

Activities

wyldckat

2016-11-06 08:41

updater   ~0007121

Found the problem: "read(dict)" was missing inside the constructor for the yPlus function object.

I then tried to find any other function objects that could have had this issue with the following command:

   find . -name "*.C" -type f | while read line; do if ! grep -q "read(dict" $line && ! grep -q "calc()" $line; then echo $line; fi; done

And I didn't spot any other classes within "src/functionObjects" missing it.


@Henry: Attached are the following files:

  - yPlus.C.4x - for OpenFOAM 4.x to replace "src/functionObjects/field/yPlus/yPlus.C"
  - yPlus.C.dev - for OpenFOAM dev to replace "src/functionObjects/field/yPlus/yPlus.C"

Changes:

  - Missing the call to read(dict) in the constructor.

  - In 4.x, was also missing an indentation when sending the "patch.name()" line to "file()"
yPlus.C.4x (6,600 bytes)

wyldckat

2016-11-06 08:41

updater  

yPlus.C.dev (6,332 bytes)

henry

2016-11-06 10:36

manager   ~0007123

Thanks Bruno

Resolved in OpenFOAM-4.x by commit acc2a7707ea657707d51bad535fe46092964b4ba

Resolved in OpenFOAM-dev by commit 26242f0de3c889746956ef22dbaebf62b891e6e5

Issue History

Date Modified Username Field Change
2016-11-06 03:20 joegi New Issue
2016-11-06 08:41 wyldckat File Added: yPlus.C.4x
2016-11-06 08:41 wyldckat Note Added: 0007121
2016-11-06 08:41 wyldckat File Added: yPlus.C.dev
2016-11-06 08:41 wyldckat Assigned To => henry
2016-11-06 08:41 wyldckat Status new => assigned
2016-11-06 10:36 henry Status assigned => resolved
2016-11-06 10:36 henry Resolution open => fixed
2016-11-06 10:36 henry Fixed in Version => 4.x
2016-11-06 10:36 henry Note Added: 0007123
2016-11-25 17:08 wyldckat Relationship added related to 0002353