View Issue Details

IDProjectCategoryView StatusLast Update
0002189OpenFOAM[All Projects] Bugpublic2016-08-14 21:42
ReporterShortyAssigned Tohenry 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSUbuntuOS Version14.04
Product Version4.x 
Fixed in Versiondev 
Summary0002189: Function nIterations() of the SolverPerformance Template class is not working for Vectors
DescriptionDear all,

I do not get the correct nIterations field if I use the SolverPerformance class for a vector field (scalar is working fine). The No. of iterations are always zero. The label that is returned is 3{0}.
Steps To ReproduceI am using some own solid stress solver but it should be able to reproduce with all other vector fields.

SolverPerformance<vector> solPerf;

solPerf = DEqn.solve();

Info<< solPerf.nIterations() << endl;

TagsNo tags attached.

Activities

henry

2016-08-12 15:01

manager   ~0006666

Resolved in OpenFOAM-dev commit 8c0718cb430ae145fb380909efc31a79c3603d89

The change is non-trivial and required a change to the SolverPerformance class, the nIterations function and templated solvers.

Please test and let me know if these changes are sufficient for your requirements.

Shorty

2016-08-12 17:35

reporter   ~0006668

Thank you Henry for the commit. The number of iterations is now displayed as expected. I already saw that the nInteration_ variable was of type label instead of labelType.

Just one hint. The solverName is for scalar fields as expected. Lets say "GAMG,DILU,...". For the vector fields it is: fvMatrix<Type>::solveSegregated and not the name of the used solver as I would expect.

Tobi

henry

2016-08-12 18:18

manager   ~0006669

fvMatrix<Type>::solveSegregated is the solver name for the vector field but not the solver name for the individual components. I will look at alternative conventions.

henry

2016-08-14 21:42

manager   ~0006670

Resolved in OpenFOAM-dev by

commit 8c0718cb430ae145fb380909efc31a79c3603d89
commit 14470c0ddad0d1df27aa17a642b439143bd99ebc

Issue History

Date Modified Username Field Change
2016-08-12 13:04 Shorty New Issue
2016-08-12 15:01 henry Note Added: 0006666
2016-08-12 17:35 Shorty Note Added: 0006668
2016-08-12 18:18 henry Note Added: 0006669
2016-08-14 21:42 henry Note Added: 0006670
2016-08-14 21:42 henry Status new => resolved
2016-08-14 21:42 henry Fixed in Version => dev
2016-08-14 21:42 henry Resolution open => fixed
2016-08-14 21:42 henry Assigned To => henry