View Issue Details

IDProjectCategoryView StatusLast Update
0002181OpenFOAM[All Projects] Bugpublic2016-08-08 15:46
ReportermarkAssigned Tohenry 
PrioritylowSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformanyOSOS Version
Product Versiondev 
Fixed in Versiondev 
Summary0002181: nullptr collateral damage
DescriptionBad changes here:

applications/utilities/mesh/conversion/ideasUnvToFoam/unv/block_with_inlet_outlet.UNV

Questionable changes here:

src/OpenFOAM/db/IOstreams/token/token*.H
NULL_TOKEN = '\0' (for nul-character, not null pointer).

STYLE: "nullptr pointer ..." sounds redundant
src/OSspecific/POSIX/regExp.C
src/OpenFOAM/containers/HashTables/HashTable/HashTable.C
src/OpenFOAM/db/functionObjects/functionObjectList/functionObjectList.H

TagsNo tags attached.

Activities

mark

2016-08-08 15:34

reporter   ~0006654

Last edited: 2016-08-08 15:34

View 2 revisions

BTW: doesn't fit at all, but also not worth opening a report.

For the primitives/int*/ could now probably also just use the following:

//- Return a word representation of an int32
inline word name(const int32_t val)
{
    return std::to_string(val);
}

Should work reliably for ints, avoids the ostringstream workaround.

henry

2016-08-08 15:46

manager   ~0006657

Resolved by commit 126813acae3d2bd87ca94e2ee052fe9a9c4f7843

Issue History

Date Modified Username Field Change
2016-08-08 15:08 mark New Issue
2016-08-08 15:34 mark Note Added: 0006654
2016-08-08 15:34 mark Note Edited: 0006654 View Revisions
2016-08-08 15:46 henry Note Added: 0006657
2016-08-08 15:46 henry Status new => resolved
2016-08-08 15:46 henry Fixed in Version => dev
2016-08-08 15:46 henry Resolution open => fixed
2016-08-08 15:46 henry Assigned To => henry