|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002175||OpenFOAM||Patch||public||2016-08-02 18:36||2016-08-03 12:22|
|Target Version||Fixed in Version||3.0.x|
|Summary||0002175: Bug in script "lagrangian/reactingParcelFilmFoam/hotBoxes/patchifyObstacles"|
|Description||In commit ecee2d275e9c2935, 20th of July 2015, there was an accidental introduction of a bug in the script "tutorials/lagrangian/reactingParcelFilmFoam/hotBoxes/patchifyObstacles": https://github.com/OpenFOAM/OpenFOAM-dev/blame/master/tutorials/lagrangian/reactingParcelFilmFoam/hotBoxes/patchifyObstacles#L74|
The change made in that commit changed this:
if [ $n -lt 10 ]; then
if [ $n -lt 10]; then
Attached is the fixed script.
I've marked this report with Severity "major", given that it essentially makes the tutorial not be properly set-up... although I'm not familiar with it and I'm not sure if there are any other bugs in this tutorial.
|Tags||No tags attached.|
|Similar happened to "tutorials/compressible/rhoCentralFoam/biconic25-55Run35/sampleCone", attached is the updated file.|
Fortunately there aren't any other tutorials affected by that commit, at least not that I can see in the commit changes.
There was one other file "tutorials/heatTransfer/buoyantSimpleFoam/externalCoupledCavity/externalSolver", but that was fixed back then the very next day.
Thanks for finding and fixing this issue Bruno
Resolved in OpenFOAM-4.x by commit 1bad0a52f1af075e01018b173d69c2d0dfb0333a
Resolved in OpenFOAM-dev by commit e301f74c93b10391f320ff1dfff0475eec2b6d4c
I didn't notice this was an issue on 3.0.x, but could you please also apply these files to the OpenFOAM-3.0.x repository?
Because I'm currently diagnosing an issue with the reactingParcelFilmFoam tutorial cases on 4.x and the results from 3.0.x are fairly different, which I'll report once I've got more details (preliminary symptoms are that the hf equation is taking a lot of time to solve on 4.x).
But since unfortunately "patchifyObstables" is also damaged on 3.0.x, it's best to have this file also fixed on 3.0.x for ensuring that the results are consistent.
I haven't checked yet if the "compressible/rhoCentralFoam/biconic25-55Run35" tutorial is also affected somehow, but it's probably best to also apply the attached fix for it too.
|Resolved by commit 4b5e129783d9bea7ea00a617b6ee3b73b0f308e4|
|2016-08-02 18:36||wyldckat||New Issue|
|2016-08-02 18:36||wyldckat||Status||new => assigned|
|2016-08-02 18:36||wyldckat||Assigned To||=> henry|
|2016-08-02 18:36||wyldckat||File Added: patchifyObstacles|
|2016-08-02 18:39||wyldckat||File Added: sampleCone|
|2016-08-02 18:39||wyldckat||Note Added: 0006616|
|2016-08-02 18:45||wyldckat||Note Added: 0006617|
|2016-08-02 19:16||henry||Note Added: 0006618|
|2016-08-02 19:16||henry||Status||assigned => resolved|
|2016-08-02 19:16||henry||Fixed in Version||=> 4.x|
|2016-08-02 19:16||henry||Resolution||open => fixed|
|2016-08-03 12:12||wyldckat||Note Added: 0006626|
|2016-08-03 12:12||wyldckat||Status||resolved => feedback|
|2016-08-03 12:12||wyldckat||Resolution||fixed => reopened|
|2016-08-03 12:21||henry||Note Added: 0006627|
|2016-08-03 12:21||henry||Status||feedback => resolved|
|2016-08-03 12:21||henry||Fixed in Version||4.x => 3.0.x|
|2016-08-03 12:21||henry||Resolution||reopened => fixed|