2017-07-23 13:37 BST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002170OpenFOAMPatchpublic2016-08-01 20:14
Reporterwyldckat 
Assigned Tohenry 
PrioritylowSeveritytextReproducibilityN/A
StatusresolvedResolutionfixed 
Product Version4.x 
Target VersionFixed in Version4.x 
Summary0002170: Typo in the tutorial "boundaryWallFunctionsProfile/Allrun"
DescriptionThe typo is in the name for the graph, which has "ANAYTICAL", when it should be "ANALYTICAL".

Attached is an "Allrun" file for replacing the one in "tutorials/incompressible/boundaryFoam/boundaryWallFunctionsProfile/Allrun", which should also apply to OpenFOAM-dev.

The patch for easier comparison is in the "Additional Information" (sorry, it's a bit quicker to report this way).
Additional Informationtutorials/incompressible/boundaryFoam/boundaryWallFunctionsProfile/Allrun
index 26d2834..e377f67 100755
@@ -43,7 +43,7 @@ then
     exit 1
 fi
 
-graphName="OF_vs_ANAYTICAL.eps"
+graphName="OF_vs_ANALYTICAL.eps"
 
 echo "Creating graph of u+ vs y+ to $graphName"
 gnuplot<<EOF
TagsNo tags attached.
Attached Files
  • ? file icon Allrun (1,647 bytes) 2016-08-01 18:28 -
    #!/bin/sh
    cd ${0%/*} || exit 1    # Run from this directory
    
    # Source tutorial run functions
    . $WM_PROJECT_DIR/bin/tools/RunFunctions
    
    runApplication blockMesh
    
    exponents="2 3 4 5 6 7 8"
    
    echo "# yPlus vs uPlus" > yPlus_vs_uPlus
    
    for e in $exponents
    do
        echo "    Setting nu to 1e-$e"
    
        sed "s/XXX/$e/g" constant/transportProperties.template \
            > constant/transportProperties
    
        runApplication -s $e  `getApplication`
    
        # extract y+, U+
        # note: both must be added to foamLog.db
        runApplication -s $e  foamLog log.boundaryFoam.$e
    
        if [ -e logs/yPlus_0 ]
        then
            yPlus=`awk < logs/yPlus_0 'END{print $2}'`
            uPlus=`awk < logs/uPlus_0 'END{print $2}'`
    
            echo "$yPlus $uPlus" >> yPlus_vs_uPlus
        fi
    
        rm -rf logs
    done
    
    
    # create validation plot
    # test if gnuplot exists on the system
    if ! which gnuplot > /dev/null 2>&1
    then
        echo "gnuplot not found - skipping graph creation" >&2
        exit 1
    fi
    
    graphName="OF_vs_ANAYTICAL.eps"
    
    echo "Creating graph of u+ vs y+ to $graphName"
    gnuplot<<EOF
        set terminal postscript eps color enhanced
        set output "$graphName"
        set grid
        set xlabel "y+"
        set ylabel "u+"
        set key top left
        set size 0.75, 0.75
        set parametric
        # u+ range
        set trange [0:35]
        # Spaldings law
        k=0.41
        E=9.8
        f(t) = t + 1/E*(exp(k*t) - 1 - k*t*(1 + 0.5*k*t) - 1/6*k*t**3)
        set logscale x
        set format x "10^{%T}"
        plot f(t),t title "Spalding" with lines linetype -1, \
            "yPlus_vs_uPlus" title "OpenFOAM" with points lt 1 pt 6
    EOF
    
    echo Done
    
    #------------------------------------------------------------------------------
    
    ? file icon Allrun (1,647 bytes) 2016-08-01 18:28 +

-Relationships
+Relationships

-Notes

~0006601

henry (manager)

Resolved in OpenFOAM-4.x by commit d0e7dc3826636ccacaa1762863eb7ae062701e3a
Resolved in OpenFOAM-dev by commit 2519a47b74ddc0022dd6ac0f4c1670c5a319a11e
+Notes

-Issue History
Date Modified Username Field Change
2016-08-01 18:28 wyldckat New Issue
2016-08-01 18:28 wyldckat Status new => assigned
2016-08-01 18:28 wyldckat Assigned To => henry
2016-08-01 18:28 wyldckat File Added: Allrun
2016-08-01 20:14 henry Note Added: 0006601
2016-08-01 20:14 henry Status assigned => resolved
2016-08-01 20:14 henry Fixed in Version => 4.x
2016-08-01 20:14 henry Resolution open => fixed
+Issue History