View Issue Details

IDProjectCategoryView StatusLast Update
0002167OpenFOAMPatchpublic2016-08-01 17:14
ReporterwyldckatAssigned Tohenry 
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0002167: "Invalid use of repetition operators" in tutorial "reactingTwoPhaseEulerFoam/laminar/bubbleColumnEvaporatingDissolving"
DescriptionIn the tutorial file "reactingTwoPhaseEulerFoam/laminar/bubbleColumnEvaporatingDissolving", the "fvSchemes" file is not escaping the asterisks that are meant to be interpreted as the multiplication operator.

Attached is the file that has this fixed, which should also be applicable to OpenFOAM-dev and 3.0.x, apart from the header.
In the "Additional Information" section below is the patch, for comparison.

The odd detail is that this fix is already in the two sibling tutorials "bubbleColumnEvaporating" and "bubbleColumn", from which I got the fix.


Side note: I only managed to spot this due to the RegEx library I'm using on Windows/MSys2... namely this one: https://github.com/laurikari/tre/ - I have no idea if it's better than the default library(ies) on Linux.
Additional Informationiff --git a/tutorials/multiphase/reactingTwoPhaseEulerFoam/laminar/bubbleColumnEvaporatingDissolving/system/fvSchemes b/tutorials/multiphase/reactingTwoPhaseEulerFoam/laminar/bubbleColumnEvaporatingDissolving/system/fvSchemes
index d562925..762dfea 100644
--- a/tutorials/multiphase/reactingTwoPhaseEulerFoam/laminar/bubbleColumnEvaporatingDissolving/system/fvSchemes
+++ b/tutorials/multiphase/reactingTwoPhaseEulerFoam/laminar/bubbleColumnEvaporatingDissolving/system/fvSchemes
@@ -40,7 +40,7 @@ divSchemes
     "div\(alphaRhoPhi.*,K.*\)" Gauss limitedLinear 1;
     "div\(alphaPhi.*,p\)" Gauss limitedLinear 1;
 
- "div\(\(\(\(alpha.**thermo:rho.*\)*nuEff.*\)*dev2\(T\(grad\(U.*\)\)\)\)\)" Gauss linear;
+ "div\(\(\(\(alpha.*\*thermo:rho.*\)*nuEff.*\)\*dev2\(T\(grad\(U.*\)\)\)\)\)" Gauss linear;
 }
 
 laplacianSchemes
TagsNo tags attached.

Activities

wyldckat

2016-08-01 15:49

updater  

fvSchemes (1,743 bytes)
/*--------------------------------*- C++ -*----------------------------------*\
| =========                 |                                                 |
| \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox           |
|  \\    /   O peration     | Version:  4.x                                   |
|   \\  /    A nd           | Web:      www.OpenFOAM.org                      |
|    \\/     M anipulation  |                                                 |
\*---------------------------------------------------------------------------*/
FoamFile
{
    version     2.0;
    format      ascii;
    class       dictionary;
    location    "system";
    object      fvSchemes;
}
// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

ddtSchemes
{
    default         Euler;
}

gradSchemes
{
    default         Gauss linear;
}

divSchemes
{
    default                         none;

    "div\(phi,alpha.*\)"            Gauss vanLeer;
    "div\(phir,alpha.*\)"           Gauss vanLeer;

    "div\(alphaRhoPhi.*,U.*\)"      Gauss limitedLinearV 1;
    "div\(phi.*,U.*\)"              Gauss limitedLinearV 1;

    "div\(alphaRhoPhi.*,Yi\)"       Gauss limitedLinear 1;
    "div\(alphaRhoPhi.*,(h|e).*\)"  Gauss limitedLinear 1;
    "div\(alphaRhoPhi.*,K.*\)"      Gauss limitedLinear 1;
    "div\(alphaPhi.*,p\)"           Gauss limitedLinear 1;

    "div\(\(\(\(alpha.*\*thermo:rho.*\)*nuEff.*\)\*dev2\(T\(grad\(U.*\)\)\)\)\)" Gauss linear;
}

laplacianSchemes
{
    default         Gauss linear uncorrected;
}

interpolationSchemes
{
    default         linear;
}

snGradSchemes
{
    default         uncorrected;
}


// ************************************************************************* //
fvSchemes (1,743 bytes)

wyldckat

2016-08-01 15:55

updater   ~0006591

And the same error happens for the sibling tutorial "bubbleColumnIATE", for which is attached the file "fvSchemes_bubbleColumnIATE".

wyldckat

2016-08-01 15:55

updater  

fvSchemes_bubbleColumnIATE (1,736 bytes)
/*--------------------------------*- C++ -*----------------------------------*\
| =========                 |                                                 |
| \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox           |
|  \\    /   O peration     | Version:  4.x                                   |
|   \\  /    A nd           | Web:      www.OpenFOAM.org                      |
|    \\/     M anipulation  |                                                 |
\*---------------------------------------------------------------------------*/
FoamFile
{
    version     2.0;
    format      ascii;
    class       dictionary;
    location    "system";
    object      fvSchemes;
}
// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

ddtSchemes
{
    default         Euler;
}

gradSchemes
{
    default         Gauss linear;
}

divSchemes
{
    default                         none;

    div(phi,alpha.air)              Gauss vanLeer;
    div(phir,alpha.air)             Gauss vanLeer;

    "div\(alphaRhoPhi.*,U.*\)"      Gauss limitedLinearV 1;
    "div\(phi.*,U.*\)"              Gauss limitedLinearV 1;

    div(phi.air,kappai.air)         Gauss vanLeer;

    "div\(alphaRhoPhi.*,(h|e).*\)"  Gauss limitedLinear 1;
    "div\(alphaRhoPhi.*,K.*\)"      Gauss limitedLinear 1;
    "div\(alphaPhi.*,p\)"           Gauss limitedLinear 1;

    "div\(\(\(\(alpha.*\*thermo:rho.*\)*nuEff.*\)\*dev2\(T\(grad\(U.*\)\)\)\)\)" Gauss linear;
}

laplacianSchemes
{
    default         Gauss linear uncorrected;
}

interpolationSchemes
{
    default         linear;
}

snGradSchemes
{
    default         uncorrected;
}


// ************************************************************************* //

henry

2016-08-01 17:14

manager   ~0006596

Resolved in OpenFOAM-dev by commit 089b50696c819c36d8e7cbe650e895ca7683e539
Resolved in OpenFOAM-4.x by commit 320efaea9944e516014d7314c7ac46b847baf0ba

Issue History

Date Modified Username Field Change
2016-08-01 15:49 wyldckat New Issue
2016-08-01 15:49 wyldckat Status new => assigned
2016-08-01 15:49 wyldckat Assigned To => henry
2016-08-01 15:49 wyldckat File Added: fvSchemes
2016-08-01 15:55 wyldckat Note Added: 0006591
2016-08-01 15:55 wyldckat File Added: fvSchemes_bubbleColumnIATE
2016-08-01 17:14 henry Note Added: 0006596
2016-08-01 17:14 henry Status assigned => resolved
2016-08-01 17:14 henry Fixed in Version => 4.x
2016-08-01 17:14 henry Resolution open => fixed