View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002079||OpenFOAM||Patch||public||2016-05-01 00:36||2016-05-01 11:10|
|Fixed in Version||dev|
|Summary||0002079: Duplicate inclusions of "createTimeControls.H" in various solvers|
|Description||I didn't bother investigating this in the historic records, but while looking into a solution for issue #1301, I stumbled upon a few solvers that are including "createTimeControls.H" twice: once outside of the time loop and once inside the time loop.|
After checking other solvers, the correct file inclusion should be "readTimeControls.H" within the time loop.
Therefore, using the following commands, I found out which were the solvers that were including the "createTimeControls.H" twice:
find . -name "*.C" -type f | while read line; do cbount=$(grep "createTimeControls" $line | wc -l); [ $cbount -gt 1 ] && echo $line; done
Attached is the package "use_readTimeControls.tar.gz" that has the updated files with the correct file inclusion.
|Tags||No tags attached.|
use_readTimeControls.tar.gz (6,468 bytes)
Thanks for cleaning this up Bruno.
Resolved by commit bc2fd6c347864389b3c72711cfb1f0bffcb0318f
|2016-05-01 00:36||wyldckat||New Issue|
|2016-05-01 00:36||wyldckat||Status||new => assigned|
|2016-05-01 00:36||wyldckat||Assigned To||=> henry|
|2016-05-01 00:36||wyldckat||File Added: use_readTimeControls.tar.gz|
|2016-05-01 11:10||henry||Note Added: 0006219|
|2016-05-01 11:10||henry||Status||assigned => resolved|
|2016-05-01 11:10||henry||Fixed in Version||=> dev|
|2016-05-01 11:10||henry||Resolution||open => fixed|