View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001932 | OpenFOAM | Bug | public | 2015-11-30 18:47 | 2015-12-01 09:47 |
| Reporter | Assigned To | henry | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | GNU/Linux | OS | Ubuntu | OS Version | 12.04 |
| Summary | 0001932: circleSet sampling points are unordered on decomposed cases | ||||
| Description | The samplingCurveDist value for each point is incorrectly calculated on the circleSet::calcSamples method: it's set as the distance euclidean to the starting point of the circle (which doens't grow monotonically with the angle of the curve. The sampledSets::combineSampledSets method combines sampled points belonging to different processes and sorts them to recover the original curve by the curveDist value of each point; hence the reported set has it's point unordered. The samplingCurveDist should simply be: samplingCurveDist.append(radius * constant::mathematical::pi/180.0*theta); instead of: samplingCurveDist.append(mag(pt - startPoint_)); | ||||
| Tags | No tags attached. | ||||
|
|
It should be noted that this only affects the order of the output if it's ordered by distance: axis distance; I've uploaded a diff of the proposed change. |
|
2015-11-30 19:45
|
circleSetOrderPatch.diff (442 bytes)
--- orig/circleSet.C 2015-11-30 15:59:20.353366105 -0300
+++ circleSet.C 2015-11-30 16:00:50.917365901 -0300
@@ -118,7 +118,7 @@
samplingCells.append(cellI);
samplingFaces.append(-1);
samplingSegments.append(nPoint);
- samplingCurveDist.append(mag(pt - startPoint_));
+ samplingCurveDist.append(radius * constant::mathematical::pi/180.0*theta);
nPoint++;
}
|
|
|
Thanks for the bug-report and proposed fix. Resolved in OpenFOAM-3.0.x by commit 51f718db3ce4d8f0b063b999de623e993b41dd85 Resolved in OpenFOAM-dev by commit 0a133a39f7f84ed7491fb6b7fbe38f29bc3d8b00 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-11-30 18:47 |
|
New Issue | |
| 2015-11-30 19:34 | wyldckat | Relationship added | related to 0001931 |
| 2015-11-30 19:45 |
|
Note Added: 0005696 | |
| 2015-11-30 19:45 |
|
File Added: circleSetOrderPatch.diff | |
| 2015-12-01 09:47 | henry | Note Added: 0005699 | |
| 2015-12-01 09:47 | henry | Status | new => resolved |
| 2015-12-01 09:47 | henry | Resolution | open => fixed |
| 2015-12-01 09:47 | henry | Assigned To | => henry |
