View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001545 | OpenFOAM | Bug | public | 2015-02-21 13:16 | 2015-02-21 14:07 |
Reporter | wyldckat | Assigned To | henry | ||
Priority | low | Severity | text | Reproducibility | N/A |
Status | resolved | Resolution | fixed | ||
Summary | 0001545: timeVaryingMappedFixedValueFvPatchField has the wrong slash for "verbatim" markers and is missing description for "offset" | ||||
Description | Tried searching for more occurrences, but fortunately there is only one: find src -name "*.[HC]" -type f | xargs grep -e "/verbatim" In addition, the "offset" option is not documented. Attached is the proposed fix for the file and in "Steps To Reproduce" is a quick git diff for easier inspection. | ||||
Steps To Reproduce | --- a/src/finiteVolume/fields/fvPatchFields/derived/timeVaryingMappedFixedValue/timeVaryingMappedFixedValueFvPatchField.H +++ b/src/finiteVolume/fields/fvPatchFields/derived/timeVaryingMappedFixedValue/timeVaryingMappedFixedValueFvPatchField.H @@ -51,17 +51,19 @@ Description perturb | perturb points for regular geometries | no | 1e-5 fieldTableName | alternative field name to sample | no| this field name mapMethod | type of mapping | no | planarInterpolation + offset | for applying offset to mapped values | no | constant 0.0 \endtable - /verbatim + \verbatim myPatch { type timeVaryingMappedFixedValue; setAverage false; //perturb 0.0; //fieldTableName samples; + //offset constant 0.2; } - /endverbatim + \endverbatim SeeAlso Foam::fixedValueFvPatchField | ||||
Additional Information | I found this one by accident, while trying to figure out how this BC worked. | ||||
Tags | No tags attached. | ||||
|
timeVaryingMappedFixedValueFvPatchField.H (8,160 bytes)
/*---------------------------------------------------------------------------*\ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | \\ / A nd | Copyright (C) 2011-2014 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License This file is part of OpenFOAM. OpenFOAM is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. OpenFOAM is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenFOAM. If not, see <http://www.gnu.org/licenses/>. Class Foam::timeVaryingMappedFixedValueFvPatchField Group grpInletBoundaryConditions grpCoupledBoundaryConditions Description This boundary conditions interpolates the values from a set of supplied points in space and time. Supplied data should be specified in constant/boundaryData/\<patchname\> where: - points : pointField with locations - ddd : supplied values at time ddd The default mode of operation (mapMethod planarInterpolation) is to project the points onto a plane (constructed from the first threee points) and construct a 2D triangulation and finds for the face centres the triangle it is in and the weights to the 3 vertices. The optional mapMethod nearest will avoid all projection and triangulation and just use the value at the nearest vertex. Values are interpolated linearly between times. \heading Patch usage \table Property | Description | Required | Default value setAverage | flag to activate setting of average value | yes | perturb | perturb points for regular geometries | no | 1e-5 fieldTableName | alternative field name to sample | no| this field name mapMethod | type of mapping | no | planarInterpolation offset | for applying offset to mapped values | no | constant 0.0 \endtable \verbatim myPatch { type timeVaryingMappedFixedValue; setAverage false; //perturb 0.0; //fieldTableName samples; //offset constant 0.2; } \endverbatim SeeAlso Foam::fixedValueFvPatchField SourceFiles timeVaryingMappedFixedValueFvPatchField.C \*---------------------------------------------------------------------------*/ #ifndef timeVaryingMappedFixedValueFvPatchField_H #define timeVaryingMappedFixedValueFvPatchField_H #include "fixedValueFvPatchFields.H" #include "FixedList.H" #include "instantList.H" #include "pointToPointPlanarInterpolation.H" #include "DataEntry.H" // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // namespace Foam { /*---------------------------------------------------------------------------*\ Class timeVaryingMappedFixedValueFvPatchField Declaration \*---------------------------------------------------------------------------*/ template<class Type> class timeVaryingMappedFixedValueFvPatchField : public fixedValueFvPatchField<Type> { // Private data //- Name of the field data table, defaults to the name of the field word fieldTableName_; //- If true adjust the mapped field to maintain average value bool setAverage_; //- Fraction of perturbation (fraction of bounding box) to add scalar perturb_; //- Interpolation scheme to use word mapMethod_; //- 2D interpolation (for 'planarInterpolation' mapMethod) autoPtr<pointToPointPlanarInterpolation> mapperPtr_; //- List of boundaryData time directories instantList sampleTimes_; //- Current starting index in sampleTimes label startSampleTime_; //- Interpolated values from startSampleTime Field<Type> startSampledValues_; //- If setAverage: starting average value Type startAverage_; //- Current end index in sampleTimes label endSampleTime_; //- Interpolated values from endSampleTime Field<Type> endSampledValues_; //- If setAverage: end average value Type endAverage_; //- Time varying offset values to interpolated data autoPtr<DataEntry<Type> > offset_; public: //- Runtime type information TypeName("timeVaryingMappedFixedValue"); // Constructors //- Construct from patch and internal field timeVaryingMappedFixedValueFvPatchField ( const fvPatch&, const DimensionedField<Type, volMesh>& ); //- Construct from patch, internal field and dictionary timeVaryingMappedFixedValueFvPatchField ( const fvPatch&, const DimensionedField<Type, volMesh>&, const dictionary& ); //- Construct by mapping given timeVaryingMappedFixedValueFvPatchField // onto a new patch timeVaryingMappedFixedValueFvPatchField ( const timeVaryingMappedFixedValueFvPatchField<Type>&, const fvPatch&, const DimensionedField<Type, volMesh>&, const fvPatchFieldMapper& ); //- Construct as copy timeVaryingMappedFixedValueFvPatchField ( const timeVaryingMappedFixedValueFvPatchField<Type>& ); //- Construct and return a clone virtual tmp<fvPatchField<Type> > clone() const { return tmp<fvPatchField<Type> > ( new timeVaryingMappedFixedValueFvPatchField<Type>(*this) ); } //- Construct as copy setting internal field reference timeVaryingMappedFixedValueFvPatchField ( const timeVaryingMappedFixedValueFvPatchField<Type>&, const DimensionedField<Type, volMesh>& ); //- Construct and return a clone setting internal field reference virtual tmp<fvPatchField<Type> > clone ( const DimensionedField<Type, volMesh>& iF ) const { return tmp<fvPatchField<Type> > ( new timeVaryingMappedFixedValueFvPatchField<Type>(*this, iF) ); } // Member functions // Access //- Return startSampledValues const Field<Type> startSampledValues() { return startSampledValues_; } // Mapping functions //- Map (and resize as needed) from self given a mapping object virtual void autoMap ( const fvPatchFieldMapper& ); //- Reverse map the given fvPatchField onto this fvPatchField virtual void rmap ( const fvPatchField<Type>&, const labelList& ); // Utility functions //- Find boundary data inbetween current time and interpolate void checkTable(); // Evaluation functions //- Update the coefficients associated with the patch field virtual void updateCoeffs(); //- Write virtual void write(Ostream&) const; }; // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // } // End namespace Foam // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // #ifdef NoRepository # include "timeVaryingMappedFixedValueFvPatchField.C" #endif // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // #endif // ************************************************************************* // |
|
Resolved by commit c0932d3f804e754ab1e386203156c4164a6d2cf9 |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-02-21 13:16 | wyldckat | New Issue | |
2015-02-21 13:16 | wyldckat | File Added: timeVaryingMappedFixedValueFvPatchField.H | |
2015-02-21 14:07 | henry | Note Added: 0003849 | |
2015-02-21 14:07 | henry | Status | new => resolved |
2015-02-21 14:07 | henry | Resolution | open => fixed |
2015-02-21 14:07 | henry | Assigned To | => henry |