View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001288 | OpenFOAM | Bug | public | 2014-05-10 15:26 | 2014-12-18 12:26 |
| Reporter | dkxls | Assigned To | henry | ||
| Priority | normal | Severity | major | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux x86_64 | OS | openSUSE | OS Version | 12.3 |
| Summary | 0001288: [ReactingParcel]: Confusing variable naming for 'minParticleMass' | ||||
| Description | According to the description in KinematicParcel, 'minParticleMass' denotes the "minimum particle mass". However, in the ReactingParcel class this quantity is used as parcel, not particle mass. Also the comments in the source code are inconsistent. The quantity has a rather big influence on spray simulation, with respect to breakup modeling and should hence be clearly defined. At a very least a note should be added in the 'sprayCloudProperties' to clarify this. | ||||
| Tags | Lagrangian | ||||
|
|
Just to note, the implementation itself is correct, just the naming is confusing. Meaning, minParticleMass should be named minParcelMass for clarity. |
|
|
This issue is still present in 2.3.1. |
|
|
Resolved by commit a15e16a5b7f391cf7ffee04cb16700f24ccbb215 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-05-10 15:26 | dkxls | New Issue | |
| 2014-05-10 15:30 | dkxls | Note Added: 0003051 | |
| 2014-05-10 15:31 | dkxls | Note Edited: 0003051 | |
| 2014-06-11 16:10 | dkxls | Tag Attached: Lagrangian | |
| 2014-12-18 10:41 | dkxls | Note Added: 0003331 | |
| 2014-12-18 12:26 | henry | Note Added: 0003333 | |
| 2014-12-18 12:26 | henry | Status | new => resolved |
| 2014-12-18 12:26 | henry | Resolution | open => fixed |
| 2014-12-18 12:26 | henry | Assigned To | => henry |
