View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001283OpenFOAMBugpublic2014-05-08 18:252014-05-09 08:58
Reporteruser920Assigned Touser2 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSFedoraOS Version20
Summary0001283: oscillatingFixedValue documentation appears to be wrong
Description$FOAM_SRC/finiteVolume/fields/fvPatchFields/derived/oscillatingFixedValue/oscillatingFixedValueFvPatchField.H describes the function applied by that BC as:
x_p = (1 + a sin(\pi f t))x_{ref} + x_o
where
        x_p | patch values
        x_{ref} | patch reference values
        x_o | patch offset values
        a | amplitude
        f | frequency [1/s]
        t | time [s]

If that were the case, the real frequency of x_p would be f/2.
Looking at $FOAM_SRC/finiteVolume/fields/fvPatchFields/derived/oscillatingFixedValue/oscillatingFixedValueFvPatchField.C shows that the function actually used is:

return 1.0 + a*sin(constant::mathematical::twoPi*f*t);

So -unless I'm overlooking something- it looks like the header need to be changed to reflect the correct formula being used.

Kind regards!
TagsNo tags attached.

Relationships

duplicate of 0001169 resolvedwill Description in "oscillatingFixedValueFvPatchField.H" has "pi" instead of "2*pi" 

Activities

shildenbrand

2014-05-09 06:34

reporter   ~0003047

see #1169

user2

2014-05-09 08:58

  ~0003048

duplicate report

Issue History

Date Modified Username Field Change
2014-05-08 18:25 user920 New Issue
2014-05-09 06:34 shildenbrand Note Added: 0003047
2014-05-09 08:57 user2 Relationship added duplicate of 0001169
2014-05-09 08:58 user2 Note Added: 0003048
2014-05-09 08:58 user2 Status new => resolved
2014-05-09 08:58 user2 Resolution open => fixed
2014-05-09 08:58 user2 Assigned To => user2