View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001281OpenFOAMBugpublic2014-05-05 10:022014-05-06 14:02
Reporterdkxls Assigned Touser2 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinux x86_64OSopenSUSEOS Version12.3
Summary0001281: [SprayParcel]: Wrong particle number for parcels introduced by the breakup model
DescriptionThis bug leads to sever mass conservation errors when the breakup model introduces new parcels.
However, at present only the KH part of the ReitzKHRT model introduces new parcels. Since the KH model is incorrectly implemented, this bug doesn't have much significances in real simulation.

I tested and fixed the bug in 2.2.x, but it applies in the same way for version 2.3.x.
Additional InformationI reported the issue with the ReitzKHRT in bug #1014. The tests for the current bug are done with a correctly implemented KHRT model.
TagsNo tags attached.

Activities

dkxls

2014-05-05 10:02

reporter  

0001-lagrangian-SprayParcel-Correct-nParticle-when-new-pa.patch (1,173 bytes)    
From 46f91daf462c1defa427bf9d0cd6e6dd179f070c Mon Sep 17 00:00:00 2001
From: Armin Wehrfritz <armin.wehrfritz@aalto.fi>
Date: Sat, 3 May 2014 19:35:44 +0300
Subject: [PATCH] lagrangian/SprayParcel - Correct 'nParticle' when new parcel
 is added by the breakup model

---
 src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C b/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C
index 30b5cac..341fb9e 100644
--- a/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C
+++ b/src/lagrangian/spray/parcels/Templates/SprayParcel/SprayParcel.C
@@ -298,7 +298,7 @@ void Foam::SprayParcel<ParcelType>::calcBreakup
         SprayParcel<ParcelType>* child = new SprayParcel<ParcelType>(*this);
         child->mass0() = massChild;
         child->d() = dChild;
-        child->nParticle() = massChild/rho*this->volume(dChild);
+        child->nParticle() = massChild/(rho*child->volume(dChild));
 
         const forceSuSp Fcp =
             forces.calcCoupled(*child, dt, massChild, Re, muAv);
-- 
1.7.10.4
0001-lagrangian-SprayParcel-Correct-nParticle-when-new-pa.patch (1,173 bytes)   

user2

2014-05-06 14:02

  ~0003044

Thanks for the report - fixed by commit 1ab61f

Issue History

Date Modified Username Field Change
2014-05-05 10:02 dkxls New Issue
2014-05-05 10:02 dkxls File Added: 0001-lagrangian-SprayParcel-Correct-nParticle-when-new-pa.patch
2014-05-06 14:02 user2 Note Added: 0003044
2014-05-06 14:02 user2 Status new => resolved
2014-05-06 14:02 user2 Fixed in Version => 2.3.x
2014-05-06 14:02 user2 Resolution open => fixed
2014-05-06 14:02 user2 Assigned To => user2