View Issue Details

IDProjectCategoryView StatusLast Update
0001003OpenFOAMBugpublic2013-09-18 14:12
Reporterdkxls Assigned Touser2 
PrioritylowSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
PlatformLinux x86_64OSopenSUSEOS Version12.2
Summary0001003: [BlobsSheetAtomization]: Wrong copy constructor
DescriptionMinor bug in the copy constructor, see patch for details.
Tagsatomization, spray

Activities

dkxls

2013-09-10 16:11

reporter  

0001-BlobsSheetAtomization-Wrong-copy-constructor.patch (1,013 bytes)   
From ca0a916beb8cb12df09dcf19249ddc82a47a1b02 Mon Sep 17 00:00:00 2001
From: Armin Wehrfritz <armin.wehrfritz@aalto.fi>
Date: Tue, 10 Sep 2013 18:09:17 +0300
Subject: [PATCH] BlobsSheetAtomization - Wrong copy constructor

---
 .../AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.C   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.C b/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.C
index c342455..63b5d4f 100644
--- a/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.C
+++ b/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.C
@@ -48,7 +48,7 @@ Foam::BlobsSheetAtomization<CloudType>::BlobsSheetAtomization
 :
     AtomizationModel<CloudType>(am),
     B_(am.B_),
-    angle_(am.B_)
+    angle_(am.angle_)
 {}
 
 
-- 
1.7.10.4

dkxls

2013-09-10 16:15

reporter  

0001-BlobsSheetAtomization-typo-in-update-function.patch (1,124 bytes)   
From 44c5c02fe284cb0a263668233fe9130cd5f32d1d Mon Sep 17 00:00:00 2001
From: Armin Wehrfritz <armin.wehrfritz@aalto.fi>
Date: Tue, 10 Sep 2013 18:13:39 +0300
Subject: [PATCH] BlobsSheetAtomization - typo in update function

---
 .../AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.H   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.H b/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.H
index 0927612..3a6c46f 100644
--- a/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.H
+++ b/libraries/lagrangian/spray/submodels/AtomizationModel/BlobsSheetAtomization/BlobsSheetAtomization.H
@@ -112,7 +112,7 @@ public:
             const scalar rho,
             const scalar mu,
             const scalar sigma,
-            const scalar volHlowRate,
+            const scalar volFlowRate,
             const scalar rhoAv,
             const scalar Urel,
             const vector& pos,
-- 
1.7.10.4

dkxls

2013-09-10 16:16

reporter   ~0002476

There is also a typo in the header file, see second patch.

user2

2013-09-18 14:12

  ~0002497

Thanks for the reports - fixed by commits 3d0a867 and 7941512

Issue History

Date Modified Username Field Change
2013-09-10 16:11 dkxls New Issue
2013-09-10 16:11 dkxls File Added: 0001-BlobsSheetAtomization-Wrong-copy-constructor.patch
2013-09-10 16:15 dkxls File Added: 0001-BlobsSheetAtomization-typo-in-update-function.patch
2013-09-10 16:16 dkxls Note Added: 0002476
2013-09-10 18:02 dkxls Tag Attached: spray
2013-09-10 18:02 dkxls Tag Attached: atomization
2013-09-18 14:12 user2 Note Added: 0002497
2013-09-18 14:12 user2 Status new => resolved
2013-09-18 14:12 user2 Resolution open => fixed
2013-09-18 14:12 user2 Assigned To => user2