View Issue Details

IDProjectCategoryView StatusLast Update
0000981OpenFOAMBugpublic2014-02-18 08:57
Reporterdkxls Assigned Touser2 
PrioritynormalSeveritytextReproducibilityN/A
Status resolvedResolutionfixed 
PlatformLinux x86_64OSopenSUSEOS Version12.2
Summary0000981: [cone*Injection]: Add info about cone angle definition
DescriptionThe the spray angle thetaInner/thetaOuter in coneInjection and coneNozzleInjection is defined as the half cone angle.

In typical spray/engine applications the spray angle is specified as the full cone angle, which leads to a high risk of errors when setting up spray simulation in OF.
Also, the dieselSpray class in 2.0.x defined the spray angle as the full cone angle, which leads to confusion when porting cases from dieselSpray to lagrangianSpray!

Hence some information about the definition should be added to the CloudProperties dictionary (see the patch for an example)! A note in the source code would also be good.
Additional InformationThe calculation of the spray angle in coneInjection and coneNozzleInjection is essentially the same, but the source code is different. This could be unified to make it easier to read (where the code in coneNozzleInjection is more straight forward concerning the randomization of the spray angel.)

When already touching the dictionaries: Some obsolete properties should be removed (Pr and Tbp, see patch).
Tagsinjection, Lagrangian, spray

Activities

dkxls

2013-08-30 10:26

reporter  

0001-Add-info-about-cone-angle-definition.patch (1,520 bytes)   
From 1269cb48b6d0385f5785d8ef6d1f82be854441bc Mon Sep 17 00:00:00 2001
From: Armin Wehrfritz <armin.wehrfritz@aalto.fi>
Date: Fri, 30 Aug 2013 11:23:22 +0300
Subject: [PATCH] Add info about cone angle definition

---
 .../aachenBomb/constant/sprayCloudProperties         |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties b/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties
index c2fd38f..41e3dee 100644
--- a/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties
+++ b/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties
@@ -136,6 +136,24 @@ subModels
 
             Cd              constant 0.9;
 
+            /* theta = half cone angle
+             * 
+             * \             |             /
+             *  \                         /
+             *   \<- theta ->|           /
+             *    \                     /
+             *     \         |         /
+             *      \                 /
+             *       \       |       /
+             *        \             /
+             *         \     |     /
+             *          \         /
+             *           \   |   /
+             *            \     /
+             *             \ | /
+             *             |   |
+             *             | | |
+             */
             thetaInner      constant 0.0;
             thetaOuter      constant 10.0;
 
-- 
1.7.10.4

dkxls

2013-08-30 10:26

reporter  

0001-Remove-obsolete-constant-properties.patch (972 bytes)   
From 51c13aa0e4fb67699596cb4140780079aac5a3e5 Mon Sep 17 00:00:00 2001
From: Armin Wehrfritz <armin.wehrfritz@aalto.fi>
Date: Fri, 30 Aug 2013 11:28:35 +0300
Subject: [PATCH] Remove obsolete constant properties

---
 .../lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties  |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties b/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties
index 41e3dee..6ed527a 100644
--- a/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties
+++ b/tutorials/lagrangian/sprayFoam/aachenBomb/constant/sprayCloudProperties
@@ -66,9 +66,7 @@ constantProperties
 
     epsilon0        1;
     f0              0.5;
-    Pr              0.7;
-    Tvap            273;
-    Tbp             373;
+    Tvap            273; // WARNING: Not used in spray simulation!
 
     constantVolume  false;
 }
-- 
1.7.10.4

user2

2014-02-18 08:57

  ~0002829

Updated in version 2.3.x

Issue History

Date Modified Username Field Change
2013-08-30 10:26 dkxls New Issue
2013-08-30 10:26 dkxls File Added: 0001-Add-info-about-cone-angle-definition.patch
2013-08-30 10:26 dkxls File Added: 0001-Remove-obsolete-constant-properties.patch
2013-08-30 10:27 dkxls Tag Attached: injection
2013-08-30 10:27 dkxls Tag Attached: Lagrangian
2013-08-30 10:27 dkxls Tag Attached: spray
2013-09-04 09:25 user2 Severity major => text
2014-02-18 08:57 user2 Note Added: 0002829
2014-02-18 08:57 user2 Status new => resolved
2014-02-18 08:57 user2 Fixed in Version => 2.3.x
2014-02-18 08:57 user2 Resolution open => fixed
2014-02-18 08:57 user2 Assigned To => user2